r/cbaduk • • Nov 25 '17

Code-review

Can we get some software engineers to audit/review the GitHub code? It seems like the learning variable bug that got fixed made a huge difference to this project. A code-review could potentially result in more bug fixes.

2 Upvotes

26 comments sorted by

3

u/isty2e Nov 25 '17

Well technically that was a mistake rather than a bug, since it was just a parameter set inappropriately. Of course, a code review would be potentially helpful, I presume.

1

u/pm_me_security_jobs Nov 25 '17

I guess it depends on the definition of a bug, but IMO the fact that the program was learning less efficiently due to a const being set incorrectly would constitute it being a bug.

3

u/AngelLeliel Nov 25 '17

We don't really know what the best learning rate is unless doing multiple experiments with different values. And we don't have the luxury as Google to experiment on large scale with hundreds of machines. Be patient.

1

u/roy777 Nov 25 '17

My understanding is it was an error on a copy of LZ on GCP's training machine, not in the github source itself?

2

u/someWalkingShadow Nov 25 '17

My understanding is that the tfprocess.py on github is a reflection of LZ on GCP's training machine. This is what allowed user kimitsu to catch the error. GCP has now fixed the error on his own machine, but has yet to update the number on github.

The reason why it says 0.05 on github right now instead of 0.1, according to GCP, is due to downscaling from smaller minibatches. If you wanted a 0.01 learning rate, it would be 0.0035 after scaling. (This is my understanding based on reading his posts. I have little machine learning knowledge; I could be wrong.)

1

u/paddingtontimes Nov 25 '17

I doubt a reviewer would have spotted that. It's more the sort of thing you catch with a test, which would likely have required non-trivial computing resources.

4

u/Neoncow Nov 25 '17

It's on github and open to view. Publicize the project and people will look at it.

2

u/Norda-Stelo Nov 25 '17

Why does this post get so many downvotes?

0

u/[deleted] Nov 25 '17

[deleted]

7

u/AngelLeliel Nov 25 '17

And the code are all open source there. Why ask others to do code review instead of just go ahead and review it. People sometimes really don't appreciate others' efforts when they get it for free.

1

u/paddingtontimes Nov 25 '17

In many places it's standard procedure that nothing can be checked in before it's been reviewed.

What's the big issue with code review anyhow? The purpose of it is to improve code or catch bugs, and not to shame developers. Think of a code reviewer like how you would think of a linter.

1

u/crispybacon404 Nov 25 '17 edited Aug 18 '25

test steep march meeting expansion long intelligent axiomatic angle sort

This post was mass deleted and anonymized with Redact

1

u/paddingtontimes Nov 25 '17

I don't quite understand your analogy. Can we stick to software engineering?

What's wrong with random people on github reviewing the work of an experienced developer? Do only idiots comment on github? Do experts never typo = as ==? Isn't one of the reasons to put code on github being to get help from others to improve it?

3

u/crispybacon404 Nov 25 '17 edited Aug 18 '25

husky price hunt thumb sip license quicksand apparatus scary hospital

This post was mass deleted and anonymized with Redact

2

u/paddingtontimes Nov 25 '17 edited Nov 25 '17

I understand now. Your point seems fair.

The problem may be because non-developers are being exposed to developer workflow, leading to not understanding the purpose of code review. Scientists should understand it as 'peer review' I would guess. If a science paper was published and someone asked if other scientists had checked a certain part of it, there wouldn't be an outcry.

1

u/Norda-Stelo Nov 25 '17

Sorry, I really didn't want to generate a polemic on this topic. I was only a bit surprised to see the post having 0 points, as it didn't seem to me in any way bad or derogatory. Anyway, now I see the point, too :-).

2

u/[deleted] Nov 25 '17

But that is not what is happening here.

It was one thing to go to github and review the code yourselves. It is a different thing to go tell others to review the code and not look at it yourself

1

u/paddingtontimes Nov 25 '17 edited Nov 25 '17

How's that different from a non-programmer wanting to support an open source project by telling programmers to check it out?

He noted a problem and suggested that a review might catch others. He's not totally wrong to come to that conclusion, even though its probably a testing issue.

In my opinion, if your code hasn't been reviewed, it's a problem. We all fuck up our code, a lot.

2

u/AngelLeliel Nov 25 '17

Code review isn't much easier than writing your own code, sometimes it's even harder. Don't ask others donate their free time like it's really free to do so.

1

u/paddingtontimes Nov 25 '17

OK, I will stop telling people to contribute GPU time to this project, since it's not really free for them to do so. Electricity bill and the gigantic opportunity cost of not being able to play video games.

1

u/AngelLeliel Nov 25 '17

Why stop here, go ahead and tell whole internet what you just said above. Look how childish you're.

→ More replies (0)