r/RequestNetwork • REQMarine • Jan 25 '18

Misleading Title Big Github Commit!

https://github.com/RequestNetwork/Request_Artifacts
58 Upvotes

30 comments sorted by

22

u/GunplaAddict Jan 25 '18 edited Jan 25 '18

These are just JSON files... There is hardly any code/logic at all from these files. As an engineer, this is far from a big github commit. If anything, it's a set of initial commits to a repo.

UPDATE: if you go to the commit tracker here, you can see that there has only been 3 commits to this repo.

10

u/AllGoudaIdeas Jan 25 '18

UPDATE: if you go to the commit tracker here, you can see that there has only been 3 commits to this repo

... that was created two hours ago.

1

u/SirRandyMarsh Jan 26 '18

Can you tell me what this means?

1

u/Jimmyl101 REQMarine Jan 25 '18

Really? I genuinely thought it was a pre-release example of how it was going to work. But I'm not a dev. My bad.

2

u/_open Jan 25 '18

Just look at the comments. "first real commit", "initial commit". Nothing big in there. Just basic setup of a new repo, so multiple people can start working on it.

5

u/The_D_boy REQMarine Jan 25 '18

Well it shows that the data structure of sending a Request is pretty final. How the data is handled is not shown in this repo.

5

u/GunplaAddict Jan 25 '18

Could you please explain how exporting your schema in to JSON files a "pretty final" data structure?

2

u/The_D_boy REQMarine Jan 25 '18

Why would you commit a data structure called prod if it is not about ready for release?

3

u/_open Jan 25 '18

Webdeveloper here. When someone in my company starts to work on a project, we set up deployment for local testing, integration, staging and production in the beginning. We do it because we want everything to go smoothly when we finally want to deploy our project.

Setting up everything when you already have a lot of code can get a lot messier, since if something goes wrong, you have a lot more sources of potential errors you have to go through. If you set it up in the beginning, you know that the deployment circle is working and if something goes wrong, the error is somewhere else.

In the end it's up to the developers what kind of workflow they prefer. I just know that's its not unusual to configure a lot from the beginning, even though you don't already need it.

3

u/AllGoudaIdeas Jan 25 '18

It is clearly defined enough for them to publish documentation and spend Ether to publish it to Rinkeby.

That does not mean it is not subject to change, but reading through the ABIs suggests all of the core is there.

4

u/Jimmyl101 REQMarine Jan 25 '18

New section on the Request Network Github, I'm sorry I doubted the work of the team earlier in the week.

4

u/[deleted] Jan 25 '18

[removed] — view removed comment

-1

u/Jimmyl101 REQMarine Jan 25 '18

I'm probably way off, as I don't know much.

What it looks like to a non dev (me) is possibly some of their MVP code (guessing that from the "rinkeby" reference in the code) for handling ethereum requests along with an example of how fees and token burn are going to work.

I think there could be some pretty mad stacks of green paper on the way.

9

u/AllGoudaIdeas Jan 25 '18

This repo appears to be the foundation of their release management tooling.

These files are "artefacts" - the output of automated build processes. For example when you create a Solidity file, you generate a JSON-formatted ABI file which describes the functionality of the contract. This repository is for storing those artefacts.

So we aren't looking at new code/features here, but we are looking at a team that knows what they are doing when it comes to agile development methods. This is an unsexy but necessary step on the path to main net release.

16

u/CallMeAwesomeSauce Jan 25 '18

As someone who's been doing web development for years and focused purely on Angular/React/React Native/Node, posts like this are starting to bother me. Please stop doing this. I say this with REQ being one of my biggest holdings. Posts like this are harmful for the community and harmful for the developers to know that every commit of theirs is being tracked or mentioned. As others have said, this is an initial scaffolding commit and it's the complete opposite of a big commit.

If you really care about the project, keep track on it's progress weeks/months at a time. Pull down the repository yourself and have the app running (if possible). Posts like this from people who have no idea about how JS frameworks or Node works is as bad as FUD.

4

u/trun333 Jan 25 '18

100% agreed

4

u/Matysekk Jan 25 '18

couldn't say it better!

2

u/patriotswin04 Jan 25 '18

when moon? lambo?

5

u/IdaXman Jan 25 '18

Can anyone explain what artifacts are? Wikipedia says they are from testing code?

5

u/AllGoudaIdeas Jan 25 '18

Artefacts are the output of automated build processes. The files in this repo are JSON-formatted ABI files, generated from Solidity smart contracts.

The benefit of this approach is that you can build an artefact and then copy it to a testing/staging server and run all of your manual or automated tests. If the tests pass you can copy the artefact to your production server, confident in the knowledge that the thing you are deploying is the same thing you tested.

4

u/GunplaAddict Jan 25 '18

Software artifacts, in general, are packaged code that is used to deploy, test or serve.

4

u/[deleted] Jan 25 '18

Dev here - these are just test/production JSON files which look to be an actual request object that will be sent when someone actually sends a request to the smart contract - I could be wrong though that’s just how it reads/what it looks like

3

u/zeCoinz Jan 25 '18

This is good news, but not so much "big". Also worth taking a look at the versioningArtifacts branch of the RequestNetwork.js project. A bit of work going on there too.

All positive steps forward I'd say. Worth keeping a eye on, for sure.

3

u/[deleted] Jan 25 '18

Awesome!

0

u/[deleted] Jan 25 '18

[deleted]

21

u/_open Jan 25 '18

Would be great if some of the mods could change the title of the topic from "big github commit" to "new github repo" or something like this. It's clearly not a big commit and it will just spread FUD if this reaches a lot of people.

12

u/mattftw1337 ICO Investor Jan 25 '18

I've tagged the post accordingly.

3

u/[deleted] Jan 25 '18

You can't edit titles on Reddit

1

u/_open Jan 25 '18

Not even mods? Didn't know about this.

4

u/[deleted] Jan 25 '18

Admins can I think but mods defintitely can not