r/RequestNetwork • REQMarine • Jan 25 '18

Misleading Title Big Github Commit!

https://github.com/RequestNetwork/Request_Artifacts
58 Upvotes

30 comments sorted by

View all comments

22

u/GunplaAddict Jan 25 '18 edited Jan 25 '18

These are just JSON files... There is hardly any code/logic at all from these files. As an engineer, this is far from a big github commit. If anything, it's a set of initial commits to a repo.

UPDATE: if you go to the commit tracker here, you can see that there has only been 3 commits to this repo.

5

u/The_D_boy REQMarine Jan 25 '18

Well it shows that the data structure of sending a Request is pretty final. How the data is handled is not shown in this repo.

5

u/GunplaAddict Jan 25 '18

Could you please explain how exporting your schema in to JSON files a "pretty final" data structure?

2

u/The_D_boy REQMarine Jan 25 '18

Why would you commit a data structure called prod if it is not about ready for release?

3

u/_open Jan 25 '18

Webdeveloper here. When someone in my company starts to work on a project, we set up deployment for local testing, integration, staging and production in the beginning. We do it because we want everything to go smoothly when we finally want to deploy our project.

Setting up everything when you already have a lot of code can get a lot messier, since if something goes wrong, you have a lot more sources of potential errors you have to go through. If you set it up in the beginning, you know that the deployment circle is working and if something goes wrong, the error is somewhere else.

In the end it's up to the developers what kind of workflow they prefer. I just know that's its not unusual to configure a lot from the beginning, even though you don't already need it.

3

u/AllGoudaIdeas Jan 25 '18

It is clearly defined enough for them to publish documentation and spend Ether to publish it to Rinkeby.

That does not mean it is not subject to change, but reading through the ABIs suggests all of the core is there.