I went through the Security Notes page properly this week rather than skimming it, and a few things in there are easy to miss. Posting them because the page is long, and most people bounce off it.
1. Super User Access. TeamCity writes a token to teamcity-server.log that allows whoever has it to log in as a system administrator. Please be careful when you've locked yourself out. Less useful if you ship logs to an external system. teamcity.superUser.disable=true in internal properties, then restart.
2. Credential scrambling is not encryption. Passwords for external systems are scrambled with 3DES and a fixed key in the Data Directory. Filesystem or DB access is enough to reverse it. There's a custom encryption key option that actually provides encryption.
3. Build-level auth parameters. Anyone with "View build configuration settings" can read them and use them to reach projects they don't have access to. teamcity.buildAuth.enableStrictMode=true closes it.
4. Empty the database on first start. A server encountering an empty DB grants access to the first person who connects. teamcity.installation.completed=true in conf/teamcity-startup.properties. Mostly relevant when restoring from backup.
5. The Default agent pool. Projects can fall back into Default after reconfiguration, and builds on the same agent are not isolated from each other. A public-PR project landing next to a private one is a real problem. Please just keep the default empty so there's nothing to fall back on.
Full page: https://jb.gg/s6o8oq
There's a short PDF version linked from it if you want something to hand to your team.
Curious which of these people actually has on. I guess that the agent pool one is most commonly missed.