r/pythonhelp • • Sep 09 '21

Help understanding functions

Number of days per month

month_days = [0, 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31] 

def is_leap(x): 
    return x % 4 == 0 and (x % 100 != 0 or x % 400 == 0) 

def days_in_month(year, month):  
        if not 1 <= month <= 12: 
            return "invalid month" 
        if month == 2 and is_leap(year): 
            return 29 
        return month_days[month]

print(days_in_month(2017, 2))

In the function: days_in_month(year, month) in the 2nd if statement how can the is_leap take in the arguement year and still be able to complete its function.

To clarify what I mean is how does the program pick up that when I assign something to the year arguement it has to run the is_leap function even though the is_leap function is coded to have the arguement of x.

If year was 12, would is_leap(year) take that 12 in and replace x with it and then run it?

3 Upvotes

10 comments sorted by

View all comments

2

u/CraigAT Sep 09 '21

I can see the question has been answered well. But I have a couple of minor related questions.

  1. The first if statement, does the "not" work as intended? Personally, I would have used brackets around everything after the "not", for clarity (excluding the colon).

  2. I was taught (in other languages) that everything needed should be passed into a function, no assumptions made. So in this case, should month_days be declared in the function, passed in as argument or 'cough' be a global variable?

2

u/xelf Sep 09 '21 edited Sep 09 '21

The first if statement, does the "not" work as intended? Personally, I would have used brackets around everything after the "not", for clarity (excluding the colon).

Adding the parenthesis for clarity is a fine thing to do. Especially when working with developers that work on multiple languages at the same time.

They're not needed though as long as you know the order of operations, and in some cases can clutter the code so much that they remove readability rather than adding to it.

In python the last three things in order of operations for operator precedence are not, then and, then or, so the comparisons are evaluated first in this case.

In other words:

not 1 <= month <= 12:

is

not ( 1 <= month <= 12 ):

because the <= are evaluated before the not.

This has more info: https://docs.python.org/3/reference/expressions.html#operator-precedence

2

u/CraigAT Sep 09 '21

Thank you, a very helpful reply!