r/programming • • Sep 30 '20

GitHub Welcomes the OpenJDK Project!

https://github.blog/2020-09-30-github-welcomes-the-openjdk-project/
67 Upvotes

11 comments sorted by

15

u/[deleted] Sep 30 '20

A few things I've noticed:

  • PR approvals are greyed, even when coming from an apparent oracle employee, probably teams are not setup correctly

  • they have the "rfr" tag (ready for review) but could use the system of draft PR

  • their actions are sometimes not triggered

  • action logs results are not public, (link to an index page)

  • PR are always closed in red although the "integrated" tag allows to distinguish a non-merged PR

So their way of using GH is a bit peculiar, I'd say, given the features.

21

u/u_tamtam Sep 30 '20

They don't plan on using github, they plan on using git and reducing expenditure (hosting, maintenance costs) for the repos they couldn't be bothered to maintain. The project management/issue tracking seems to remain on prem/jira (which would make a ton of sense for a big/established project that probably sees itself outliving github and its contribution model flavor of the month by far).

10

u/[deleted] Sep 30 '20

so everything happens elsewhere and is transformed, using the API, into something that looks like if a GH user made an action, e.g approval are not made on the GH itself.

That'd explain all.

-10

u/LloydAtkinson Oct 01 '20

So basically exactly as you'd expect a shitty organisation like Oracle to have setup their development practices.

22

u/Tweenk Oct 01 '20

Google uses a similar model for some of their projects that they mainly develop internally, for example googletest and TensorFlow.

IDK, for some people it's emotionally important to have green boxes on merged PRs, but I wouldn't care as long as the code is accepted and merged.

I would even go as far as saying that the obsession with keeping your GitHub activity history green is actively detrimental to software quality. It promotes hacks and papering over problems instead of actually understanding and fixing them.

8

u/u_tamtam Oct 01 '20

Agreed. To me the whole point/strength of github, its contribution model and its "gamified" features is to encourage drive-by/fixups kind of contributions.

That makes a ton of sense for small/hobby projects, or organizations that don't have predictability/capacity planning.

For anything else, you end-up with a very limited issue tracker, idiotic code review, no release management, and no QA.

I find it ridiculous how the big projects out there are coping with it by piling up bots and web hooks of all sorts, and how ad-hoc and clunky the whole thing end up looking.

10

u/nutrecht Oct 01 '20

It makes no sense for a company that already uses for example Jira with issue tracking to move that to Github. It doesn't have a good issue tracker, and they probably have integrations with Jira everywhere.

The company I work for uses Gitlab for example, but they use Jira for issue tracking. The issue tracker in Gitlab itself is pretty bad.

-7

u/mestresamba Oct 01 '20

Is using Github so hard that worth building a huge pipeline to act was if they are using? This is so fucking dumb.

7

u/u_tamtam Oct 01 '20

it's not dumb, it's just telling that, for them, GitHub isn't the place where the important stuff takes place. I wouldn't blame them for that considering that GitHub is very opinionated about how your project should be managed, and I kind of agree that it sucks.

-6

u/LloydAtkinson Oct 01 '20

Fully agreed

11

u/[deleted] Sep 30 '20

Seems like a great move for the Java community