Wow really really well written. I've got to save this for future reference. Those are all pretty major shortcomings of Drupal. The most frustrating is getting rid of the stock UI. That crap always finds a way to seep into your design.
Can you clarify what you mean about the node system not letting you do programmatic saves? Or was the key word 'reliably'? If so yeah I'd have to concur.
The problem is really the node_form and how it shapes the code around it. The idea is that you take the entire $node, you turn it into a $form structure with fields, which is then shown to the user. Then the submitted form values are serialized back into a new $node (which is made secure through Form API access control on fields).
This is dumb, because it elevates the form fields from just a UI implementation aspect into meaningful structure. It also means you need a comprehensive bidirectional translation scheme between $node and $form, which in practice means people get lazy and make forms that look like airplane cockpits.
But where it gets really problematic is that many contrib modules (out of ignorance) don't even bother translating back from $form to $node, and hardcore their node_save() callbacks to accept only the $form values. Passing in a vanilla $node will simply not work and result in data loss, aggravated by silent failure and those crazy type casts PHP is famous for.
As far as I'm aware, the only way this has changed in 7 is that the $form fields are now automagically combined with the original $node, so that values not present in the $form are not lost. But otherwise, module authors are still expected to grasp MVC-related concepts in a system that has neither the vocabulary nor the grammar to express these ideas fluently.
Thanks for the awesome flow chart and info. I've got to ask about one more thing you've brought up. I've long suspected the global $user object to be a bit, well, suspect. Though it hasn't bitten me in the ass yet, I feel like I'm just waiting for the other show to drop as our program gets more and more complex. Could you elaborate on any known problems or is there anything I should keep in mind when coding to save myself some sanity in regards to $user in the future?
1
u/[deleted] Jan 06 '11
Wow really really well written. I've got to save this for future reference. Those are all pretty major shortcomings of Drupal. The most frustrating is getting rid of the stock UI. That crap always finds a way to seep into your design.
Can you clarify what you mean about the node system not letting you do programmatic saves? Or was the key word 'reliably'? If so yeah I'd have to concur.