r/programmerchat • u/[deleted] • Jul 07 '15
Hiring Engineers/developers whom write code that works (with bad design skills)
I'm currently looking for someone to help me build mobile apps.
I've been working alone for the past 5 years, and I think its time to expand.
The problem is, most software engineers/developers I interviewed have little to no design skills, and when I look at their code it has:
functions that are too long (30+ loc).
Views code handled in the ViewControllers.
Network, UI, Serialising and DataBase code in the same class.
but few of them has the experience at least, meaning that they've done basically every common thing that is expected from a mobile developer. and they've been doing it for years.
So is it a good idea to hire someone like that, and hope they learn a better way to write software as they go, or this is a red flag. meaning if they didn't care about design, good, modular code they can't start now ?
2
u/odiefrom Jul 07 '15
There's pretty much two ways that can shake down: either they haven't learned good standards yet and will take them up when you introduce your design documentation and rules, or they will ignore you and trudge in their ways because that's just how they work.
When you are looking to hire someone, it's critical to evaluate how receptive they are to learning new things, we don't know everything after all. If they answer beyond the canned "I'm always interested in expanding my skills," perhaps even probe into how they feel about developing new coding standards, then you should get an idea on if you want to hire them.
2
Jul 07 '15
I completely agree, one's attitude towards learning is one of the main treats of a good software engineer.
1
u/KZISME Jul 07 '15
What is a good way to not fall into these bad habits? - coming from someone who is graduating in the spring and looking for a job sooner or later.
1
u/Berberberber Jul 28 '15
Work with people that have good habits. If every class is well specialized and every method does one thing, it's easier to write code yourself that does that. If you have to make use of a class that parses JSON, writes to the database, and logs errors, it's a lot harder to keep your designs clean.
0
Jul 07 '15
My personal experience, is read other's code, blogs, books, discussions, podcasts, videos anything you can find.
The quest for quality is a never ending one, and you can learn about it almost everywhere.
1
u/KZISME Jul 07 '15
I'll keep that all in mind (and I do that already)
I just hope I'm up to par when looking for work :)
2
Jul 07 '15
I think the attitude is enough to be honest, most bad code, comes from people who don't care about quality as the top comment is saying.
1
u/KZISME Jul 07 '15
I try heh I just hope that's enough! I graduate in the spring and I'm not sure what to expect (although I am currently working as an intern developer)
2
Jul 07 '15
Yes, it is a good idea. People learn through training, especially good design skills. Design comes the slowest for most developers (including myself), you can read all the books in the world but if you haven't been burned several times you probably haven't learned : ) Just try to weed out the ones who seem to be indifferent and apathetic. Hard to tell, I know.
1
u/Berberberber Jul 28 '15
This is a good opportunity for in-depth interviews. Have them do a mock review of your code and then you do a mock review of something they wrote. Or present them with an architectonic problem you faced and ask them how they would solve it (one you've also solved in your codebase already, please - it's not right to ask people to do real work for you in an interview).
Depending on your needs it might not be a bad idea to start with someone with less experience, as you might be able to mold their habits into good ones. An enthusiastic beginner can be worth more than a mediocre or apathetic veteran, especially long-term.
0
Jul 07 '15
[deleted]
4
Jul 07 '15
thanks a lot ! I'll need to find out for myself I suppose which one they are.
The problem is that its sometimes a bit of each.
4
u/AllMadHare Jul 07 '15
I would also add "get it done" - itis, some devs can fall into the trap of writing so much code that will likely never get touched they just make it work and never get to the phase of making it nice, it may get a client off your back but isn't going to make you a better coder.
12
u/ietsrondsofzo Jul 07 '15
30 lines of code is too long for a single function? Woah.