This is a good explanation of what happened, but I object to the title "event-stream vulnerability explained".
The vulnerability is very straightforward. dominictarr gave control of the repo to right9ctrl. That was the only vulnerability, which is why it's the only thing everyone is discussing.
If you give someone the keys to your house and he steals your money, how he manages to steal your money might be an interesting question, but "vulnerability" isn't the right word for it. The lock had no vulnerability. It did its job: it only let people with the key into your house.
Most of the comments on GitHub are asking the question of why there's no way to develop JavaScript without giving five hundred people the keys to your house. And I can't blame them; it's entirely valid to consider that a more important question than how someone managed to steal money undetected for a few months, after being given a house key.
Yeah, imo, this is really 100% dominiccarr's fault. NPM can take every precaution they want and it will never stop some package creator willingly transferring control of their package to a malicious actor without vetting them.
I'm shocked that people in the original issue thread were defending his decision to hand over such a popular repo to some random GitHub account with little activity and no previous commits to the repo. And people were defending his decision because of the "as-is" clause in the MIT license.
Is he legally responsible? Clearly not. Is he morally responsible? Absolutely.
Did you send him any money for event-stream? No? Then fuck you, you ain't got shit right to complain or criticize when a volunteer doesn't devote even more of their time to giving you free shit.
This is true. However open source is bound by trust, dominiccarr broke that trust. Repos get deprecated all the time, the choice is to deprecate, not hand the users over to a random person.
dominiccarr was the target of social engineering - it's likely he was not the only one as well. He and everyone else needs to be aware of and guard against this as a method of injecting code.
3
u/Serei Nov 27 '18 edited Nov 27 '18
This is a good explanation of what happened, but I object to the title "event-stream vulnerability explained".
The vulnerability is very straightforward. dominictarr gave control of the repo to right9ctrl. That was the only vulnerability, which is why it's the only thing everyone is discussing.
If you give someone the keys to your house and he steals your money, how he manages to steal your money might be an interesting question, but "vulnerability" isn't the right word for it. The lock had no vulnerability. It did its job: it only let people with the key into your house.
Most of the comments on GitHub are asking the question of why there's no way to develop JavaScript without giving five hundred people the keys to your house. And I can't blame them; it's entirely valid to consider that a more important question than how someone managed to steal money undetected for a few months, after being given a house key.