r/javascript • • Jun 20 '16

Javascript developers, be warned about this crazy JIT bug in V8!

Last week I've spent a full day to fix very strange behavior in a single page application for my customer that only happens on Chrome 51 (maybe 52, but not in Canary 53).

After a while our SPA started behaving incorrectly...

It turned out to be a nasty bug in the V8 JIT engine.

Try the following in Chrome's developer console:

function foo() {
  return typeof null === "undefined";
}

for(var i=0; i<10000; ++i) console.log(foo())

This should of course always print false, but in Chrome 51, it prints true after about about 100 iterations (it varies...)

I want to warn other web-developers for this bug, to avoid many $$$ being wasted (or becoming insane ;-))

 

EDIT: The following - more realistic case that we had in third-party library code - will also fail, but after about 10 thousand iterations:

function isUndefined(thing){
    return typeof thing === "undefined";
}

for(var i=0; i<100000; i++) console.log(isUndefined(null));

 

EDIT: The bug also manifests itself with the more common pattern

typeof x !== "undefined"

UPDATE: I just tried this with the latest stable Chrome (52.0.2743.82), and it now works correctly :)

482 Upvotes

117 comments sorted by

View all comments

Show parent comments

8

u/[deleted] Jun 21 '16

He probably isn't but iterating over a list of entires with a lot of nulls and getting false positives. Use some common sense, bud.

-1

u/Jafit Jun 21 '16

So you'd use typeof variable === "undefined" to look for null... when typeof null === "object"?

That's not a great way to look for null values, bud.

1

u/[deleted] Jun 21 '16

Super cool, but again you are assuming what his production code looks like. Either it doesn't look like that at all -or- he is doing something "not a great way". It doesn't matter.

Either way, my statement still stands.

1

u/ziriax Jun 22 '16

I edited my post, to reflect the real code. The code was part of thirdparty libraries that checked if a value was undefined. Many popular libraries have code likes that.