r/javascript • • Jun 20 '16

Javascript developers, be warned about this crazy JIT bug in V8!

Last week I've spent a full day to fix very strange behavior in a single page application for my customer that only happens on Chrome 51 (maybe 52, but not in Canary 53).

After a while our SPA started behaving incorrectly...

It turned out to be a nasty bug in the V8 JIT engine.

Try the following in Chrome's developer console:

function foo() {
  return typeof null === "undefined";
}

for(var i=0; i<10000; ++i) console.log(foo())

This should of course always print false, but in Chrome 51, it prints true after about about 100 iterations (it varies...)

I want to warn other web-developers for this bug, to avoid many $$$ being wasted (or becoming insane ;-))

 

EDIT: The following - more realistic case that we had in third-party library code - will also fail, but after about 10 thousand iterations:

function isUndefined(thing){
    return typeof thing === "undefined";
}

for(var i=0; i<100000; i++) console.log(isUndefined(null));

 

EDIT: The bug also manifests itself with the more common pattern

typeof x !== "undefined"

UPDATE: I just tried this with the latest stable Chrome (52.0.2743.82), and it now works correctly :)

482 Upvotes

117 comments sorted by

View all comments

2

u/AlGoreBestGore Jun 20 '16

While this is trippy, when would you need to check if null's type is undefined?

0

u/[deleted] Jun 20 '16

[deleted]

1

u/Buckwheat469 Jun 20 '16 edited Jun 20 '16

I've created 4 different examples, after moving some code around I can no longer get it to reproduce the problem on the last 3 examples. The first example still returns true on Chrome 51 Linux x64. I want to point out that it did reproduce the error more often at first but I noticed some bad code and moved some functions around. This seemed to fix the problem.

https://jsfiddle.net/sssn9fvo/2/

Edit: I just noticed that the link above has an extra foo() function. As soon as I deleted this function it started working. Perhaps the interpreter is jumping between 2 different hoisted functions?

https://jsfiddle.net/sssn9fvo/3/