r/javascript • • Jun 20 '16

Javascript developers, be warned about this crazy JIT bug in V8!

Last week I've spent a full day to fix very strange behavior in a single page application for my customer that only happens on Chrome 51 (maybe 52, but not in Canary 53).

After a while our SPA started behaving incorrectly...

It turned out to be a nasty bug in the V8 JIT engine.

Try the following in Chrome's developer console:

function foo() {
  return typeof null === "undefined";
}

for(var i=0; i<10000; ++i) console.log(foo())

This should of course always print false, but in Chrome 51, it prints true after about about 100 iterations (it varies...)

I want to warn other web-developers for this bug, to avoid many $$$ being wasted (or becoming insane ;-))

 

EDIT: The following - more realistic case that we had in third-party library code - will also fail, but after about 10 thousand iterations:

function isUndefined(thing){
    return typeof thing === "undefined";
}

for(var i=0; i<100000; i++) console.log(isUndefined(null));

 

EDIT: The bug also manifests itself with the more common pattern

typeof x !== "undefined"

UPDATE: I just tried this with the latest stable Chrome (52.0.2743.82), and it now works correctly :)

482 Upvotes

117 comments sorted by

View all comments

6

u/Cosmologicon Jun 20 '16

Good find. In case anyone is wondering, according to the bug report, checking for equality to undefined directly is not affected:

if (x === undefined) ...

So those of us who do it this way don't have to worry about this particular bug.

5

u/[deleted] Jun 20 '16

You do, however, have to worry about whether or not x is defined, as x === undefined will throw an error where typeof x === "undefined" won't.

1

u/Cosmologicon Jun 20 '16 edited Jun 20 '16

True, I'm not recommending you change your code. But if you're already using this construct in places where it works (eg checking whether a function argument was specified), you don't need to worry about the bug.

2

u/[deleted] Jun 20 '16

Correct! I probably should've been more clear, I was just throwing some information out for others who didn't know.