r/javascript • • Jun 20 '16

Javascript developers, be warned about this crazy JIT bug in V8!

Last week I've spent a full day to fix very strange behavior in a single page application for my customer that only happens on Chrome 51 (maybe 52, but not in Canary 53).

After a while our SPA started behaving incorrectly...

It turned out to be a nasty bug in the V8 JIT engine.

Try the following in Chrome's developer console:

function foo() {
  return typeof null === "undefined";
}

for(var i=0; i<10000; ++i) console.log(foo())

This should of course always print false, but in Chrome 51, it prints true after about about 100 iterations (it varies...)

I want to warn other web-developers for this bug, to avoid many $$$ being wasted (or becoming insane ;-))

 

EDIT: The following - more realistic case that we had in third-party library code - will also fail, but after about 10 thousand iterations:

function isUndefined(thing){
    return typeof thing === "undefined";
}

for(var i=0; i<100000; i++) console.log(isUndefined(null));

 

EDIT: The bug also manifests itself with the more common pattern

typeof x !== "undefined"

UPDATE: I just tried this with the latest stable Chrome (52.0.2743.82), and it now works correctly :)

482 Upvotes

117 comments sorted by

View all comments

45

u/fforw Jun 20 '16

Happens in Chrome 51, 64-bit Linux, too.

And it is clearly not a case of undefined behavior.

5

u/daytodave Jun 20 '16

Got it in Chrome 51, but it took 12292 iterations.

1

u/Browsing_From_Work Jun 21 '16

Odd. When I do the comparison as a function it takes fewer iterations.

function f() { return typeof null !== "undefined"; }
var i; for (i = 0; f(); i++); console.log(i);
// Outputs 12291, then subsequently starts outputting zeroes

Versus:

var i; for (i = 0; typeof null !== "undefined"; i++); console.log(i);
// Reliably outputs 18436