r/javahelp • • Nov 20 '20

Homework How to swap two elements in ArrayList<ArrayList<String>>

So I have an ArrayList of an ArrayList. The first ArrayList has the lines of a txt file, and the second -the individual words from each line.

ArrayList<String> lines=new ArrayList<>();
 lines=fileIntoArray(fileName); ArrayList<ArrayList<String>>
 words=new ArrayList<>(); words.add(lines); 

I want to swap two words, word1 from line1 with word2 from line2

-Before swap

word1 word2 word3

word4 word5 word6

-After swap

word5 word2 word3

word4 word1 word6

I tried to swap them using a String temp, but it gave me an IndexOutOfBoundsException

The indexes are entered by the user

String swap1=words.get(firstLineIndex).get(firstWordIndex); 
String swap2=words.get(secondLineIndex).get(secondLineIndex); 
String temp=null; 
temp=swap1; 
swap1=swap2; 
swap2=temp;

Any help would be greatly appreciated. Thank you in advance.

21 Upvotes

5 comments sorted by

•

u/AutoModerator Nov 20 '20

Please ensure that:

  • Your code is properly formatted as code block - see the sidebar (About on mobile) for instructions

  • You include any and all error messages in full

  • You ask clear questions

  • You demonstrate effort in solving your question/problem - plain posting your assignments is forbidden (and such posts will be removed) as is asking for or giving solutions.

    Trying to solve problems on your own is a very important skill. Also, see Learn to help yourself in the sidebar

If any of the above points is not met, your post can and will be removed without further warning.

Code is to be formatted as code block (old reddit: empty line before the code, each code line indented by 4 spaces, new reddit: https://imgur.com/a/fgoFFis) or linked via an external code hoster, like pastebin.com, github gist, github, bitbucket, gitlab, etc.

Please, do not use triple backticks (```) as they will only render properly on new reddit, not on old reddit.

Code blocks look like this:

public class HelloWorld {

    public static void main(String[] args) {
        System.out.println("Hello World!");
    }
}

You do not need to repost unless your post has been removed by a moderator. Just use the edit function of reddit to make sure your post complies with the above.

If your post has remained in violation of these rules for a prolonged period of time (at least an hour), a moderator may remove it at their discretion. In this case, they will comment with an explanation on why it has been removed, and you will be required to resubmit the entire post following the proper procedures.

To potential helpers

Please, do not help if any of the above points are not met, rather report the post. We are trying to improve the quality of posts here. In helping people who can't be bothered to comply with the above points, you are doing the community a disservice.

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

6

u/zfolwick Nov 20 '20

Neat problem! Are you sure it needs to be `ArrayList<ArrayList<String>>` ?

It seems like this should be (without testing this locally):

ArrayList<String> lines = new ArrayList<>();  
lines = fileIntoArray(fileName); 
ArrayList<String> words = new ArrayList<>(); 
lines.foreach( line -> words.add(line.split(" ")));

Should be a bit cleaner and give the same console output.

in your swap code, should
String swap2=words.get(secondLineIndex).get(secondLineIndex);
Actually be

String swap2=words.get(secondLineIndex).get(secondWordIndex);
?

Everything else seems legit.

4

u/throwawyrand Nov 20 '20

Yes it should be like that, thank you for pointing it out.

I think it should be an ArrayList<ArrayList<String>> because it's an array of the words of each line in a text file (the lines are stored in an ArrayList).

Also after the swapping, the file should be updated with the changes.

4

u/amfa Nov 20 '20

But it's not.

words is a Arraylist that has one entry only.
This entry is a Array with your lines.

So this
String swap2=words.get(secondLineIndex).get(secondLineIndex);

Can not work.. there is no second line index.

If you want to use this "double array" you would need to go over every line, split this line intos words, add those words to one array.. and then add this array to your words array.

6

u/leroybentley Nov 20 '20

You can't update the strings in the lists by doing '='. You'll need to use the Lists'.set(index, newStr) method