r/javahelp • • Nov 28 '19

Math.Random keeps generating the same Value

I'm generating a 12 digit number for a Credit card. it must be 12 digits but random. have this line for code here :

debitCardNumber = (int) (Math.random() * Math.pow(10,12));
But, it keeps generating this value over and over: 2147483647.

In addition its 10 digits and not 12!

16 Upvotes

16 comments sorted by

View all comments

5

u/NautiHooker Software Engineer Nov 28 '19

you are casting it to an int. thats the max value for an signed 32 bit integer. try lowering the factor that u calculate with the pow function or use a datatype that is larger than an int (long comes to mind)

1

u/Alaa13 Nov 28 '19

Okay. this credit number is stored in a database. I must change the data type of that column to long as well!

8

u/[deleted] Nov 28 '19

Better: just use a string. A CC number is a numeric string you do transforms and hashes on, not a number you use in calculations.