r/javaScriptStudyGroup • • Nov 10 '17

Noob looking for help

Hi all,

I'm currently trying to code a simple JavaScript game. I'm using a children's study book called 'Creating with Code - Develop your own game' (CoderDojo). It's a step-by-step approach to create this game: http://www.nano-tips.com/nanonautspringt/

Anyway: I succeeded in creating the background and the guy. The next step is to make my guy jump... That's where I need some help. I just can't make it work... What am I doing wrong? This is the relevant part of the code:

// CONSTANTEN

var CANVAS_BREEDTE = 800;
var CANVAS_HOOGTE = 600;
var NANONAUT_BREEDTE = 181;
var NANONAUT_HOOGTE = 229;
var GROND_Y = 540;
var NANONAUT_Y_VERSNELLING = 1;
var SPATIEBALK_CODE = 32
var NANONAUT_SPRONG_SNELHEID = 20;

// INSTELLINGEN

var canvas = document.createElement('canvas');
var c = canvas.getContext('2d');
canvas.width = CANVAS_BREEDTE;
canvas.height = CANVAS_HOOGTE;
document.body.appendChild(canvas);

var spatiebalkIsIngedrukt = false;

var nanonautAfbeelding = new Image();
nanonautAfbeelding.src = 'nanonaut.png';

var achtergrondAfbeelding = new Image();
achtergrondAfbeelding.src = 'achtergrond.png';

var nanonautX = 50;
var nanonautY = 40;

var nanonautYsnelheid = 0;

window.addEventListener('keydown', onKeyDown);
window.addEventListener ('keyup', onKeyUp);
window.addEventListener('load', start);

function start() {
window.requestAnimationFrame(hoofdlus);
}



// HOOFD-LUS

function hoofdlus () {
update ();
draw ();
window.requestAnimationFrame(hoofdlus);
}

// SPELER-HANDELINGEN

function onKeyDown(event) {
if (event.keyCode === SPATIEBALK_CODE) {
spatiebalkIsIngedrukt = true;
}
}

function onKeyUp(event) {
if (event.keyCode === SPATIEBALK_CODE) {
spatiebalkIsIngedrukt = false;
}
}


// UPDATEN

// Update de Nanonaut.

function update() {
if (spatiebalkIsIngedrukt) {
nanonautYSnelheid = -NANONAUT_SPRONG_SNELHEID;
}

nanonautY = nanonautY + nanonautYsnelheid;
nanonautYsnelheid = nanonautYsnelheid + NANONAUT_Y_VERSNELLING;

if (nanonautY > (GROND_Y - NANONAUT_HOOGTE)) {
nanonautY = GROND_Y -NANONAUT_HOOGTE;
nanonautYsnelheid = 0
}
}
3 Upvotes

6 comments sorted by

1

u/Volv Nov 10 '17

If you can post it all I can have a go at spotting the problem, although I must admit the Dutch does not make it easy :)

1

u/nw030 Nov 11 '17

Thanks for your reply! I copied my code below. btw: the correct code for the whole game is to be found here: http://www.nano-tips.com/volledigecode/) But even this cheat-page doesn't help me ;)

Thanks in advance!

<!doctype html>

<html> <head> <title>Nanonauten in actie</title> </head> <body> <script>

// CONSTANTEN

var CANVAS_BREEDTE = 800;
var CANVAS_HOOGTE = 600;
var NANONAUT_BREEDTE = 181;
var NANONAUT_HOOGTE = 229;
var GROND_Y = 540;
var NANONAUT_Y_VERSNELLING = 1;
var SPATIEBALK_CODE = 32
var NANONAUT_SPRONG_SNELHEID = 20;

// INSTELLINGEN

var canvas = document.createElement('canvas');
var c = canvas.getContext('2d');
canvas.width = CANVAS_BREEDTE;
canvas.height = CANVAS_HOOGTE;
document.body.appendChild(canvas);

var spatiebalkIsIngedrukt = false;

var nanonautAfbeelding = new Image();
nanonautAfbeelding.src = 'nanonaut.png';

var achtergrondAfbeelding = new Image();
achtergrondAfbeelding.src = 'achtergrond.png';

var nanonautX = 50;
var nanonautY = 40;

var nanonautYsnelheid = 0;
var nanonautIsInDeLucht = false;

window.addEventListener('keydown', onKeyDown);
window.addEventListener ('keyup', onKeyUp);
window.addEventListener('load', start);

function start() {
window.requestAnimationFrame(hoofdlus);
}



// HOOFD-LUS

function hoofdlus () {
update ();
draw ();
window.requestAnimationFrame(hoofdlus);
}

// SPELER-HANDELINGEN

function onKeyDown(event) {
if (event.keyCode === 32) {
console.log("Spatiebalk ingedrukt") = true;
}
}

function onKeyUp(event) {
if (event.keyCode === 32) {
spatiebalkIsIngedrukt = false;
}
}


// UPDATEN

// Update de Nanonaut.

function update() {
if (spatiebalkIsIngedrukt) {
nanonautYSnelheid = -NANONAUT_SPRONG_SNELHEID;
}

nanonautY = nanonautY + nanonautYsnelheid;
nanonautYsnelheid = nanonautYsnelheid + NANONAUT_Y_VERSNELLING;

if (nanonautY > (GROND_Y - NANONAUT_HOOGTE)) {
nanonautY = GROND_Y -NANONAUT_HOOGTE;
nanonautYsnelheid = 0
}
}




// TEKENEN

function draw () {

// Teken de lucht.

c.fillStyle = 'rgb(135, 206, 250)';
c.fillRect (0, 0, CANVAS_BREEDTE, GROND_Y - 40);

// Teken de achtergrond

c.drawImage(achtergrondAfbeelding, 0, -210);

// Teken de grond.

c.fillStyle = 'rgb(34, 139, 34)';
c.fillRect (0, GROND_Y - 40, CANVAS_BREEDTE, CANVAS_HOOGTE - GROND_Y + 40);

// Teken de Nanonaut.
c.drawImage(nanonautAfbeelding, nanonautX, nanonautY);
}	

</script> </body> </html>

2

u/Volv Nov 11 '17

Your main issue was capitalisation of a variable.
I have been through and added some comments, as well as fixed the variable.
You can have a look here - https://codepen.io/volv/pen/BmRBWZ?editors=0011

2

u/nw030 Nov 14 '17

Thank you so much. This helped and gave me the boost to continue!

2

u/Volv Nov 14 '17

Awesome. Let me know if you have any other issues / how you get on :)

1

u/Volv Nov 11 '17

Have only just got to this now. Will see if I can see anything, just so you dont think I've ignored it :)