OpenJDK's main repository transition to GitHub is done
http://mail.openjdk.java.net/pipermail/jdk-dev/2020-September/004694.html13
u/ddumanskiy Sep 05 '20
Does that mean it would be possible to contribute via GitHub PRs? Or this is just read-only repo like it was before?
16
u/pron98 Sep 05 '20
All contributions from now on to the mainline project will be through PRs. But you still have to sign the OCA, go through the mailing lists and pass review, of course.
6
u/vips7L Sep 05 '20
I thought you guys were automating the mailing list stuff through github?
24
u/pron98 Sep 05 '20
Yes. I meant that unsolicited contributions are not recommended, and it's best to discuss a proposed change on the mailing list before offering a PR. But a review of a PR is two-way mirrored between the mailing lists and GitHub, so that anyone is free to use whichever mechanism they prefer for the review.
4
u/henk53 Sep 06 '20
But a review of a PR is two-way mirrored between the mailing lists and GitHub
What I do wonder, there's hundreds of thousands of projects on GitHub just using PRs. There are some exceptionally large projects among those as well.
What makes the JDK project different so that it needs two-way mirrored PR system? Has anyone else ever felt that need? Is this need among other projects so big that maybe this should be a core feature in GitHub itself?
7
u/pron98 Sep 06 '20
I don't know if I'd call that a "need," but 1/ the mailing lists are the existing workflow, and 2/ we do not want to cede all that vital data to a third party; this way we have it mirrored on our servers, just like the git repo itself.
1
u/henk53 Sep 07 '20
I specifically understand 2/. Of course nobody ever wants to cede vital data.
The thing I mostly wonder about, why is it only OpenJDK for which this is needed. E.g. Linux is not a small project either, and neither is Rails or Git itself. Why do those project don't need the mailing list, and are thus seemingly all okay with ceding the vital data?
(I know you can't answer for those projects, but it just makes me wonder)
4
u/pron98 Sep 07 '20 edited Sep 07 '20
I could be wrong, but I believe both Linux and git work similarly to OpenJDK, and do mirror PRs on their mailing lists; I also think they support a workflow that doesn't use GitHub at all. I don't know much about RoR, but it's significantly smaller than OpenJDK in code size, activity and certainly impact and usage. I think that if you look at the world's biggest open-source projects (somehow taking into account code size, activity, and impact) -- OpenJDK isn't in the top 3, but it's probably in the top 10 -- not counting the projects owned by Microsoft, quite a few don't rely solely on GitHub (linux, git, Chromium/V8, Postgres), especially those that predate GitHub.
In any event, as time goes on, I guess it's possible that the workflow will be changed.
1
u/yawaramin Sep 06 '20
That’s cool. Is that custom tooling or is there something that allows any project to mirror mailing lists and PRs?
3
3
6
u/Sebazzz91 Sep 06 '20
And they use a master branch. Does that mean the complaints about "master=slavery=racism" have died down, the OpenJDK team does not care, or that the time for virtue signalling is over?
3
u/gibriyagi Sep 05 '20
Is there a reason why issues are not moved to github?
15
u/nlisker Sep 06 '20
The JBS on JIRA is way more extensive than GitHub issues, allowing for many types of issues, issue linking, setting reported and fix versions etc.
8
u/pron98 Sep 06 '20 edited Sep 06 '20
There are multiple reasons. For one, GitHub issues do not currently provide the required level of access and visibility control we require and are missing some other features that are important to our current workflow. For another, while the git repo can be easily cloned and mirrored on internal servers under our control -- and, indeed, it is -- allowing easy migration of the data should we want to transition off of GitHub, the same cannot currently be said about GitHub issues. The bug database is a vital resource, over which we're not ready to give full control to a third party.
4
u/rastaman1994 Sep 05 '20
As someone unfamiliar with compilers and such, where does the 13% c++ come from?
30
10
u/Skhmt Sep 05 '20
Theres the actual VM, then there's native things that have to be done in c++, like anything to do with the filesystem or networks for example.
1
4
u/rp_ush Sep 05 '20
Where was it before?
6
5
u/henk53 Sep 05 '20
Hg repo, but with the forest extension.
Maybe the forest was great for devs who knew it, but for most people I knew it was quite unintelligible. Say you were looking for a source file in JDK8u32, which you would somehow find. But then that repo was seemingly empty. Where were the rest of the files? Well, somewhere in the forest, seemingly.
9
u/Areshian Sep 05 '20
The JDK repo was no longer using the forest extension, it was consolidated back during JDK10 days.
Jdk8u, where the work to keep OpenJDK8 updated is done, is still using the forest extension. And it is still hosted in the mercurial servers.
2
u/Hall_of_Famer Sep 06 '20
Thats a good move, glad Java is making this switch and its been great that Java has received quite a lot of new updates and features in the last 1-3 years.
2
1
1
u/DJDavio Sep 06 '20
Interestingly enough, the version is already set to 16, with 15 due to come out September 15th.
3
u/Raurits Sep 06 '20
Indeed, but this is as expected. Rampdown Phase One (fork from main line) was on 2020/06/11, see https://openjdk.java.net/projects/jdk/15/.
0
Sep 05 '20
[deleted]
27
u/bwRavencl Sep 05 '20
6
u/13steinj Sep 05 '20
Are a lot of these guys just not on the core team (pulls accepted) or don't have github accounts? Or if neither, they shoud add a mailmap.
39
u/Ilookouttrainwindow Sep 05 '20
After so many years, microsoft finally got their hands on java