r/java • • Jul 26 '20

OpenJDK Migrates to Github

https://www.infoq.com/news/2020/07/openjdk-github-migration/
213 Upvotes

37 comments sorted by

6

u/RapunzelLooksNice Jul 26 '20

Wouldn’t GitLab be a better choice? Once it is in GitHub, it should be easier to move away to another Git I guess...

72

u/pron98 Jul 26 '20

Here are some steps we've taken to not overly depend on GitHub:

  1. Issues stay on a self-hosted JIRA.

  2. For each PR, a bot automatically generate a patch that's posted to the mailing list, and all comments are two-way mirrored between GH and the mailing list.

  3. All links to commits in issues don't point directly at GH but at an indirection through our domain.

  4. All bots work on both GH and GitLab

This means that we can move off of GH pretty much instantly if the need arises. But self-hosting just wouldn't serve our goals. We want speed all around the world, and we don't want to spend resources on administration.

2

u/pmarschall Jul 27 '20

What bots do you have? Here is what would be incredibly useful:

  • post the build results

  • OCA check

6

u/pron98 Jul 27 '20 edited Jul 27 '20

We do an OCA check, a review check and a lint check. Also, an automatic squash, and mirroring to and from the mailing list. Not sure about build results -- maybe it's up to the respective project.

Here's an example

1

u/neopointer Jul 27 '20

I can understand why ppl still use JIRA, but for open source it's just so much better to use GitHub. It's something that ppl will take into consideration before creating a bug, you know, having to maybe remember another user+pass, etc... Kinda annoying

8

u/kaperni Jul 27 '20 edited Jul 27 '20

I don't really think Java Bug Database with more than 300.000 issues represents the average-sized open source project. Transitioning from Jira would probably be a multi-year effort similar to the Mercurial->Git transition.

3

u/neopointer Jul 28 '20

hmmm, true... I didn't think about that...

2

u/[deleted] Jul 27 '20

having to maybe remember another user+pass

This is what password managers are for

1

u/neopointer Jul 28 '20

Sure. Like everyone uses it. Yes, it's more common nowadays, but still...

1

u/brunocborges Jul 28 '20

Actually, the password thing is not an issue at all for JIRA on the OpenJDK project, because unless you become a member of the OpenJDK project, you won't have an account in its JIRA.

But yes, anyone can look into most of the tickets in JIRA (Security Vulnerabilities is one of those areas that are not entirely public).

1

u/neopointer Jul 28 '20

I meant to report issues, not to see. Anyhow, it's not a strong argument, it's just that, well, you know how lazy ppl can be.

1

u/brunocborges Jul 28 '20

You don't need a JIRA Account to submit bugs

1

u/neopointer Jul 28 '20 edited Jul 28 '20

Ok, that's new to me then. I assumed you needed an account to be able to report a bug. I'm used to projects from companies like redhat where they not only use JIRA, but also require an account.

42

u/EhWhoAmI Jul 26 '20

On the other hand, github has better visibility on search engines and integration with other services.

5

u/solonovamax Jul 27 '20

I've seen many projects use gitlab, but then have it mirrored over to GitHub with some disclaimer saying the actual project is on gitlab.

4

u/kaperni Jul 27 '20

I would see that as more complexity rather than an added feature.

1

u/solonovamax Jul 27 '20

Fair point

2

u/polothedawg Jul 27 '20

Yeah, you can also have bidirectional mirroring if the need arises, comes in handy occasionally

-7

u/Bloom_Kitty Jul 26 '20

What kind of services would you want with github other than git?

16

u/woj-tek Jul 27 '20

CI?

10

u/[deleted] Jul 27 '20

Upvoted, though it's worth mentioning that Gitlab also has their own share of CI services on offer.

1

u/woj-tek Jul 27 '20

I know, but it was about "integration" and IMHO Gitlab is geared more towards "offering more build in" while GitHub is being more of a platform which can integrate with virtually everything.

5

u/neopointer Jul 27 '20

Why would Gitlab be a better choice?

6

u/[deleted] Jul 27 '20

GitHub was bought by Microsoft and there's a part of the OSS community that views it as toxic now because of that.

15

u/neopointer Jul 27 '20

This is a very silly argument.

2

u/RapunzelLooksNice Jul 27 '20

Why do you find it silly? Microsoft has a known history of Embrace, extend, and extinguish strategy.

-2

u/[deleted] Jul 27 '20

I agree lol.

2

u/edubkn Jul 27 '20

Github

better support for code reviews

Can ever only pick one

2

u/Gundea Jul 27 '20

I take it you’ve never contributed code to an OpenJDK project?

2

u/edubkn Jul 28 '20

Right. But doing code reviews in Github is painful. I hope it gets better with the fresh new UI

4

u/Gundea Jul 28 '20

Doing code reviews for OpenJDK projects in the past involved sending out an email with a JIRA link and a link to a WebRev, which was generated by running a zsh script locally and r-syncing it to a correctly formatted path on cr.openjdk.java.net. This resulted in a completely static page, so no in-line comments on the code. Any reviews had to be done via e-mail, followed by a new webrev.

I know some opinions in this differ, but I prefer the Github PR/Code-review flow so much more.

2

u/edubkn Jul 28 '20

Yeah that sounds like some 80's thing

1

u/Gundea Jul 29 '20

Hence why Github means better support for code reviews.

-31

u/[deleted] Jul 27 '20 edited Jul 27 '20

Just in case somebody didn't know... github is owned by Microsoft now.

2

u/wildjokers Jul 27 '20

🤷‍♂️