r/java • u/BlueGoliath • Jul 26 '20
OpenJDK Migrates to Github
https://www.infoq.com/news/2020/07/openjdk-github-migration/2
u/edubkn Jul 27 '20
Github
better support for code reviews
Can ever only pick one
2
u/Gundea Jul 27 '20
I take it you’ve never contributed code to an OpenJDK project?
2
u/edubkn Jul 28 '20
Right. But doing code reviews in Github is painful. I hope it gets better with the fresh new UI
4
u/Gundea Jul 28 '20
Doing code reviews for OpenJDK projects in the past involved sending out an email with a JIRA link and a link to a WebRev, which was generated by running a zsh script locally and r-syncing it to a correctly formatted path on cr.openjdk.java.net. This resulted in a completely static page, so no in-line comments on the code. Any reviews had to be done via e-mail, followed by a new webrev.
I know some opinions in this differ, but I prefer the Github PR/Code-review flow so much more.
2
-31
Jul 27 '20 edited Jul 27 '20
Just in case somebody didn't know... github is owned by Microsoft now.
2
6
u/RapunzelLooksNice Jul 26 '20
Wouldn’t GitLab be a better choice? Once it is in GitHub, it should be easier to move away to another Git I guess...