r/java • • Jun 29 '17

Basic neural network Java implementation, which can train itself, for beginners to try out and learn how machine learning works.

https://github.com/sebig3000/MachineLearning
264 Upvotes

28 comments sorted by

View all comments

29

u/ron_krugman Jun 30 '17

A few remarks on style:

  • Always put a block with curly braces after if, while, etc. even if there is just a single statement within and braces are technically optional.

  • Prefer enums over int constants. They are strongly typed in Java, which makes it much harder to accidentally pass an invalid value.

  • Throw a java.lang.IllegalArgumentException in case of an invalid input. It is more concise and saves you the trouble of checked exceptions.

  • Also, you probably shouldn't ever instantiate a java.lang.Exception directly. Throw a java.lang.RuntimeException if you're not sure about what type of exception to throw.

2

u/sebig3000 Jun 30 '17

Thank for the tips! I'm still a student and started to learn how to code Java one year ago so I'm still a newbie. But I will apply your advice!

3

u/[deleted] Jun 30 '17

You can also make identifier names more meaningful so you don't need as many comments. For example, numberOfInputs instead of input_n.