r/java • • Aug 11 '15

Top 10 Useful, Yet Paranoid Java Programming Techniques

http://blog.jooq.org/2015/08/11/top-10-useful-yet-paranoid-java-programming-techniques/
181 Upvotes

76 comments sorted by

View all comments

Show parent comments

2

u/[deleted] Aug 12 '15

[removed] — view removed comment

1

u/PaulRivers10 Aug 13 '15

Just to make sure we're on the same page, final behaves similar to how const does in C++. For value types, that means their value cannot be changed. For reference types, that means their reference cannot be changed.

Not exactly though, the difference is in C++ you can pass an object as a value type. For objects really only has "const" for pointers and references.

And that's where we get into the problem, using a final object to store you mutable variable is not actually any different than using a primitive. Adding final onto the reference doesn't add anything. But that's the workaroudns you've suggested with this:

For mutable state, use final objects (references) instead of value types.

That's trying to cheat your way around the philosphy.

final iterable references can be iterated over without any problems.

Because only your reference to the Iterator is final. If all of the instance variables inside Iterator were also final like was suggested, it wouldn't work at all.

So, going back to the initial point. The bugs that final has helped me catch are typically re-assignments & never-assignments, mostly through legacy code. Cases like an object having a property that is only assigned in n of n+1 constructors, or reassigned in constructor x that calls constructor y and then does work. For methods, a particular branch was re-assigning an input argument without considering later code flow. Another case, a giant horrific mess was re-assigning the same reference multiple times through multiple branches.

I guess I haven't been working with legacy code that complex or that initially badly written.

If it works for you great, but for the most part I suspect more would have been gained when it was written if it followed other better philosophies about writing clear and maintainable code, than declaring everything final.

I mostly work on web apps. You're usually just shuttling data between the browser and the database, no one is trying to modify the data to begin with.

If java had C++'s notion of const-ness, as in const data as well as reference, I would be as much of a fan of slathering it everywhere that I could. Yes, in some cases you need mutability. Depending on the work being done, in the case of numerical algorithms, yea, sure, mutate state as much as you need. It sounds as if your work falls into this category. In other domains, the safety guarantee that no part of the code could possibly be modifying state is a huge maintenance win.

This week I happened to be working with javascript. About 50% of the variables were looping and counters that had to be mutable, the other 50% could have been "final" if javascript had the keyword but no one was going to be trying to reassign to them in the code anyways. No one is trying to reassign "checkbox5" to another value.

I've been doing java development for over 10 years and am often the person cleaning up and fixing others code. That doesn't make me automatically right or anything like that, but it comes from experience seeing the half-baked fads come through.

Now I ask myself "can I actually see the problem this is solving". And I can't. I think final everywhere would make it longer to write code, harder to read, and be more of an annoyance for maintenance than a help.

Technically any language could make it's variables const by default, and require a special keyword to make them mutable. But I don't know any widely used languages where anyone thought that was really a good enough idea to do things that way either.

2

u/[deleted] Aug 13 '15

[removed] — view removed comment

1

u/PaulRivers10 Aug 13 '15

Lol, I just quite my last job (finally) because of having to deal with people like you that had a huge ego and no connection between internet ideas and that their changes caused huge delays and increases in time to get anything done on our project.

Like I said, there are no languages that do things that way that also become popular - for very good reason.

Have fun making everything take 3x longer to write with no benefit though.

1

u/[deleted] Aug 13 '15 edited Aug 13 '15

[removed] — view removed comment

→ More replies (0)