r/github • • Sep 03 '24

Cute

Post image
265 Upvotes

13 comments sorted by

25

u/tkdeng Sep 04 '24

Older yoda was a senior. He knew not to push Anakin to master.

5

u/TungusChan Sep 04 '24

This is ridicilous! How could i be a contributor amd not be able to push to master!

4

u/physisPaysSis Sep 05 '24

That's outrageous! That's unfair!

2

u/UntamedBelle Sep 05 '24

Be he will more powerful, may the code be with you! 

7

u/Solomoncjy Sep 04 '24

Push to master on my fork,. Thaen open a pr against master on real repo

3

u/r2k-in-the-vortex Sep 04 '24

Use the --force young padawan.

7

u/acnicholls Sep 04 '24

Not that I do, but what's the joke? I mean real repos lock master and require PR to it, but amateurs push to the master/main branch all the time, there's really nothing wrong with it.

1

u/Ieris19 Sep 05 '24

It’s not about real repo. It’s mostly about scale. Any repo with more than 2 contributors should do PRs, but a small team can simply push to master.

There’s nothing wrong with it, and doing a PR for your solo project would be pointless.

1

u/acnicholls Sep 05 '24

Not entirely pointless.

  1. It teaches you the flow in a “safe” repo that you don’t have to worry about

  2. Lets you see the changes specific to your fix or feature, so you can detect bad patterns

  3. Helps show you how to review code

  4. Allows for PR workflows

1

u/Ieris19 Sep 05 '24

Okay, then the only argument would be learning. All workflows on a PR are overkill for a single person or can be triggered on push

1

u/acnicholls Sep 05 '24

Yep, 100% Although, with compiled languages a build action on PR is a good idea. The number of times, at work, where there were no build actions on PRs, and another dev would push something that didn’t build and we’d have to back and do ANOTHER PR just to fix the fix….uggh. Build action on PR = deployment bliss

4

u/VelvetWhiteRabbit Sep 04 '24

I do all the time. Straight to prod!

1

u/betelgozer Sep 04 '24

His mergiConflictians are off the charts!