7
3
7
u/acnicholls Sep 04 '24
Not that I do, but what's the joke? I mean real repos lock master and require PR to it, but amateurs push to the master/main branch all the time, there's really nothing wrong with it.
1
u/Ieris19 Sep 05 '24
It’s not about real repo. It’s mostly about scale. Any repo with more than 2 contributors should do PRs, but a small team can simply push to master.
There’s nothing wrong with it, and doing a PR for your solo project would be pointless.
1
u/acnicholls Sep 05 '24
Not entirely pointless.
It teaches you the flow in a “safe” repo that you don’t have to worry about
Lets you see the changes specific to your fix or feature, so you can detect bad patterns
Helps show you how to review code
Allows for PR workflows
1
u/Ieris19 Sep 05 '24
Okay, then the only argument would be learning. All workflows on a PR are overkill for a single person or can be triggered on push
1
u/acnicholls Sep 05 '24
Yep, 100% Although, with compiled languages a build action on PR is a good idea. The number of times, at work, where there were no build actions on PRs, and another dev would push something that didn’t build and we’d have to back and do ANOTHER PR just to fix the fix….uggh. Build action on PR = deployment bliss
4
1
25
u/tkdeng Sep 04 '24
Older yoda was a senior. He knew not to push Anakin to master.