r/cpp • • May 07 '16

Visual Studio adding telemetry function calls to binary?

http://imgur.com/TiVrXyf
596 Upvotes

211 comments sorted by

View all comments

105

u/spongo2 MSVC Dev Manager May 10 '16

hi everyone. This is Steve Carroll, the dev manager for the Visual C++ team.

Tl;dr: thanks folks for the feedback. Our team will be removing this from our static libs in Update 3.

Our intent was benign – our desire was to build a framework that will help investigate performance problems and improve the quality of our optimizer should we get any reports of slowdowns or endemic perf problems in the field.

We apologize for raising the suspicion levels even further by not including the CRT source, this was just an oversight on our part. Despite that, some of you already investigated how this mechanism works in nice detail. As you have already called out, what the code does is trigger an ETW event which, when it’s turned on, will emit timestamps and module loads events. The event data can only be interpreted if a customer gives us symbol information (i.e. PDBs) so this data is only applicable to customers that are actively seeking help from us and are willing to share these PDBs as part of their investigation. We haven’t actually gone through this full exercise with any customers to date though, and we are so far relying on our established approaches to investigate and address potential problems instead.

We plan to remove these events in Update 3. In the meantime, to remove this dependency in Update 2, you should add notelemetry.obj to your linker command line. If you’re generally concerned about phone-home scenarios, more information about how to configuring Windows 10 appropriately to your needs can be found here: https://technet.microsoft.com/en-us/itpro/windows/manage/configure-windows-10-devices-to-stop-data-flow-to-microsoft#bkmk-priv-feedback

Thanks.

38

u/c0r3ntin May 10 '16 edited May 10 '16

Thank you for the answer

I don't think burning the feature down is necessary. But put it behind a flag, or better yet, in a separate library / object that must explicitly be linked/called.

Our intent was benign – our desire was to build a framework that will help investigate performance problems and improve the quality of our optimizer should we get any reports of slowdowns or endemic perf problems in the field.

Great. But the CRT should not be "a framework that will help investigate performance problems". That's better left to the FTWHIPP.

Sane defaults yada yada.

11

u/spongo2 MSVC Dev Manager May 10 '16

yep, appreciate that feedback.

34

u/lee171 Jun 10 '16

If you’re generally concerned about phone-home scenarios, more information about how to configuring Windows 10 appropriately to your needs can be found here: https://technet.microsoft.com/en-us/itpro/windows/manage/configure-windows-10-devices-to-stop-data-flow-to-microsoft#bkmk-priv-feedback[1] Thanks.

That is a ginormous list of things to do, to opt out of handing practically endless amounts of marketing/analytics data to Microsoft.

Just sayin'.

13

u/spamcop1 Jun 10 '16

exactly, this is crazy and shady stuff

11

u/SexualDeth5quad Jun 13 '16

And all your privacy and security precautions can be nullified at any time by Microsoft with a convenient autoupdate.

5

u/ProgramTheWorld Jun 12 '16

And still there are people saying that you just need to flip one switch in the control panel to turn it all off.

5

u/SexualDeth5quad Jun 13 '16

Those people are paid Microsoft apologists.

28

u/SexyMonad Jun 10 '16

After the outcry against how telemetry snuck into Windows 10, I simply cannot understand why your team would add it without notifying developers. It's like the entire company is oblivious to the PR fuck up it has been.

17

u/SexyMonad Jun 10 '16

Oh and I have a habit of defending Microsoft, but not here. Now you're starting to burn my bridge.

13

u/emergent_properties Jun 10 '16

I was a Windows fanboy.

I defended Windows XP's Fisher Prince Luna interface way back a decade ago.

I defended Windows Vista because it was just unfamiliar and Windows 7 was their successful attempt at capturing the same magic, so I recommended that to everyone I knew.

No longer.

Microsoft has turned Windows into the Bill Cosby of operating systems.

→ More replies (2)

8

u/slurpme Jun 10 '16

I remember having an argument (on reddit) with a MS employee about the changes W8 was bringing, they were insistent that the future was touch screen devices... MS and their koolaid/insulation has been a long standing problem...

7

u/[deleted] Jun 11 '16

Most regular users are going to be (and are) using touch screen devices. Think about how many phones and tablets are used by everyone from kids to grandparents every single day. A lot of people don't even have desktops or laptops. The problem was win8 was ahead of its time.

8

u/slurpme Jun 11 '16

For touch based devices yes, not for desktop computers which is what they were are arguing for... There are very few people who want gorilla arms...

5

u/Aetheus Aug 06 '16

Agreed. Many people use Windows for their workstations. Most people require (or at least heavily appreciate) the precision of being able to point and click in a specific area of the screen and not having to pray that the cursor selects what they intend it to select.

Touchscreens can complement your workflow, but I don't see them completely replacing the mouse anytime soon. Desktop applications with complex menus like Microsoft Excel are painful to use with a touchscreen.

→ More replies (1)

48

u/exoflat May 11 '16

I'm not buying the benign part.

You write blog posts for practically everything you do in the compiler, how come you didn't write one to survey people's opinions or at least warn them about this?

44

u/emergent_properties Jun 09 '16

"We got caught. We'll roll back this one."

12

u/spongo2 MSVC Dev Manager May 11 '16

hi! thanks for the reply and to be honest, I'm actually quite happy that people are noticing our more open stance. We try hard to make sure the message gets out about the work we do. In this particular case, we decided to abandon this plan almost as soon as the code was completed so we never got to the point where we publicized it. I agree that it would have been good to survey this one in advance.

12

u/TemplateRex May 12 '16

Weakened version of Hanlon's razor, never assume malice when oversight will suffice

5

u/interger May 11 '16

This needs more visibility. Care to link this directly as a top-level submission to /r/cpp?

6

u/spongo2 MSVC Dev Manager May 11 '16

to be honest, I'm never quite sure what the appropriate reddiquette is on points like this. I really value this forum as a way to gather information on trends in cpp and a way to get a head's up on issues like this so I try to be pretty cautious with things that might be considered self-promotion. In this particular case I added a top level comment and then linked to it from places that people specifically called me via /u/spongo2. :) but, my comment above is now the team's plan of record and I'm not trying to hide it or anything.

3

u/interger May 11 '16

I'm just a little concerned as this post got a lot of views, but few will be interested enough to check back for updates (though I for one was kind of stalking your account for the last few days :p). Simply I want for those other people [that don't check back or don't care about MSVC] to know what's up as they may have formed an (quite negative) impression that would matter when they do start to care doing stuff in MSVC.

4

u/rfog-rfog Jun 11 '16

Now the only logical thing you must have to do to eliminate all suspects, is put all the runtime and startup source code available to the community and that code will be compilable and generate the same runtimes and startups we have in our Visual Studios editions. Once read this, my manager has told me to move to GCC.

→ More replies (21)