r/RequestNetwork • • Jan 15 '18

Development Skepticism

Overview

A recent poster asked for REQ FUD from the community. I created this reddit account with the intention of auditing upcoming 'hyped' coins, so without believing I would find much or anything for REQ, that's what I set out to do.

My concern lies with the content and rate of code development. The following is copied from my response to the initial call for FUD.


The github is... abysmal.

The team has two developers listed. Vincent Rolland as the lead engineer, and Elliot Dennis as a full stack engineer.

Vincent is the main developer for the Request.js codebase. This is the core library. Request.js has a total of 143 total commits and very little code. Days go by where only very minor commits are made (a misspelling of a word is fixed...) The code has virtually no documentation. There is no real testing suite to be seen. It in no way resembles enterprise code. It looks more like someone's side project. Feel free to check out the commits for yourself: https://github.com/RequestNetwork/requestNetwork.js/commits/master.

Elliot Dennis, the full stack engineer, appears to have made his first github contribution in 2016, indicating at least that he's relatively new to professional development - although of course he may just not have used github before then. Elliot's contribution so far is in the form of 98 commits, amounting to the simple web app which is their colossus alpha. It's a tiny web app. It makes a few calls to Request.js and it displays information. That appears to be the total sum of 2 months work.

Some of REQ's goals:

  • Request works with every global currency.

  • Request is designed to be flexible, to last hundreds of years, and to work with IoT, whilst being compatible with any future systems.

  • Financial invoicing

I understand that it's clearly a work in progress, but at this rate it will take years and years of development to reach any of these milestones. The code is updated every few days with minor edits and additions. Financial invoicing is not even remotely close to being part of this project yet. The team has two developers who are being asked to undertake mammoth tasks, and from what I can see are not equipped to do so in the timeframes given. I have seen more code and more work in university group projects.

Feel free to compare it to the github of Raiblocks with 2435 commits and mountains of dense intricate code, testing suites, and 22 contributors constantly working on it. Notwithstanding the fact that Raiblocks may have its own issues, that's the sort of github you want to see - not this.


If other devs would like to take a look at the code and share their thoughts I'd be happy to hear them, as there may be facets to this project I'm not seeing.

4 Upvotes

36 comments sorted by

24

u/xyourself Jan 15 '18

Hi, developer here.

Just checked the code. Their github is just documentation and their JavaScript api. This api is a simple layer that interfaces with the Request network. So essentially once the available calls are defined this library doesn’t need to change much. Think of it like there are only a few things this thing will ask the backend: create payments, check invoices etc. For example twitter’s api doesn’t change much, it’s just stuff like post a new tweet, get profile info, blah blah but behind the scenes the twitter code base is massive and always changing.

You’d only need or assign one or two devs to create a public JavaScript api like this.

The actual Request network code does not appear to be public anywhere and with their roadmap I’d assume it’s trucking along in a private repo somewhere.

1

u/coinSceptic Jan 15 '18 edited Jan 15 '18

Well that was my initial thought as well - it was just a public API wrapper for Request, and perhaps the substance was elsewhere. But if you actually look at the code, you'll find that the substantive calls are made to the Request-Contract library which is also public. The Request-Contract library does the processing and stores data on the IPFS. That Request-Contract library has had little to no work done on it in months. Outside the request-contract library I do not see calls to a separate code base - please correct me if I'm wrong.

https://github.com/RequestNetwork/ represents the efforts of three developers. The core Request-Contracts (which are being externally audited as the basis of REQ), the javascript library/API, and the front end code for the website Colossus request test.

You’d only need or assign one or two devs to create a public JavaScript api like this.

Well it appears they have. The two developers listed on the Team page on the website. This is the req codebase.

5

u/thekcoinz Investor Jan 15 '18

I think XRB is a better investment for you based on what you think. I’m sorry but you are completely out of topic here. You are comparing 2 projects one was in 2014 and one that started end of last year. Request Network is backed by Y Combinator so I would rather follow something They back rather than listen to your poor feedback. Thank you anyway and feel free to sell your Req and buy XRB instead.

3

u/coinSceptic Jan 15 '18

I'm not comparing REQ to XRB. They are completely different projects. I'm looking at the work being done in the repository. I only mention XRB as an example for those wanting to look at what a healthy and active github project in the crypto space looks like.

2

u/thekcoinz Investor Jan 15 '18

Well, thank you for your feedback.

2

u/LyeInYourEye Jan 15 '18

This is just their api right?

1

u/coinSceptic Jan 15 '18 edited Jan 15 '18

That is their entire framework. The Request.js library for making requests, and the App frontend. There is also the repo for the contract code which has not been updated in months.

3

u/mattftw1337 ICO Investor Jan 15 '18

Please keep in mind that Request Networks fundamental design involves the Request Hub. The team are obviously setting out to tackle the fundamental design of the Network and solve the major milestones but incentivising third party devs has always been part of the plan, and there's plenty of reasons that third parties should be interested in working on top of Request.

1

u/donksewer911 Jan 15 '18

Don't know that much about code but you sound like wayyy more of a sbillster than he does a FUDster. He's trying to open a dialogue with a contradicting point of view that seems fairly professionally assessed and level headed, and you're, well making a few good points but you're also getting emotional and attacking him personally more than you are answering his questions by the end of this argument. Great post OP, thanks for your perspective

2

u/coinSceptic Jan 16 '18

Oh, thanks. With a notable exception I think most people here have generally been willing to discuss the issues rather than dismiss them outright or attack me personally even if they disagree, and that's pretty healthy. It's also a testament to the sub that mods haven't deleted the post. When subreddits start banning all potentially negative content you should really get worried.

5

u/dodoei Jan 15 '18

I had the same concerns and got downvoted to abyss LOL. One argument is that they have private repositories that are not public yet

2

u/patriotswin04 Jan 15 '18

Do you know code?

1

u/dodoei Jan 15 '18

Do you mean coke cola?

3

u/patriotswin04 Jan 15 '18

No I was generally asking if you can read and write code. Because I can't so I have no idea if this is true or not

0

u/[deleted] Jan 15 '18

[deleted]

1

u/coinSceptic Jan 15 '18

New account, true, but the substance of what I'm saying should be able to be refuted without simply saying "new account fud".

I flat out disagree with that code review. I don't see why anyone would be impressed with it. Even basic industry practices like commenting code are absent, but if other developers all disagree, then perhaps my standards are skewed.

Yes Raiblocks has more commits as it's been around longer, but it is updated constantly with substantial commits. That's my main point. It's an active codebase with plenty of ongoing work. Commits to the REQ repo over the last month by contrast have been minor amendments and tinkering. There does not appear to be significant work underway, and it if is it's particularly slow.

The REQ pitch is ambitious. It's a huge project. What we have in terms of code right now is years away from meeting what they have set out in their roadmap.

9

u/AllGoudaIdeas Jan 15 '18

Even basic industry practices like commenting code are absent,

This is demonstrably untrue. There are copious comments throughout the code - including in docstrings so documentation can be automatically generated, as it is done in any professional project.

It seems like your "code review" consisted solely of counting the number of contributors on GitHub, and not actually looking at any code, otherwise you would have noticed the comments.

-3

u/coinSceptic Jan 15 '18

Ok, you're right, if you set aside the absence of code in many areas, the core sections do have commented code. To say "absent" was misleading.

What I was really trying to make clear was that I'm concerned with the amount of work being done. Look through the commit history and dive into the substance of each commit. There has been very little substantive work done over the past month. The codebase feels like it's in a maintenance pattern - not gearing up to release features that will fulfill the roadmap promises. Features that will require huge amounts of work.

8

u/AllGoudaIdeas Jan 15 '18

Look through the commit history and dive into the substance of each commit.

I have done this previously and saw no reason for concern. The roadmap said they would deliver an MVP on test net - the combined commits add up to an MVP on test net, delivered on schedule. That is what matters.

There has been very little substantive work done over the past month.

This is just as misleading as your comment on code comments.

The last month included Christmas, New Year's, and the team moving to Singapore to work alongside the Kyber team, and was also the period during which they released Colossus and request.js.

It sounds like you are scraping the barrel to come up with concerns, and failing to find anything of significance. Your complaint amounts to "a startup has a lot of work to do before their product is complete", which is true of every startup. If someone wants to invest in a company with a complete product, AAPL or TSLA might be a better option.

-3

u/coinSceptic Jan 15 '18

Ok, perhaps a few commits every second day is a usual and healthy amount of work for a multi million dollar business relying solely on the outcome of that work to progress. In 3 months we will be at the end of Q1 2018, and they will have either delivered or they won't have. Judging by what I'm seeing, I find it very unlikely. In any event I'll return to this thread and send you a message. If you're right, and they have just been busy with extracurricular activities recently, then I'll accept I reviewed their work unfairly. If not, you should give more consideration to the concerns I've raised.

9

u/AllGoudaIdeas Jan 15 '18

Ok, perhaps a few commits every second day is a usual and healthy amount of work for a multi million dollar business relying solely on the outcome of that work to progress.

Your bias is transparent. Every comment is awkwardly phrased so as to squeeze in as much negativity as possible.

In 3 months we will be at the end of Q1 2018, and they will have either delivered or they won't have.

Actually 2.5 months, but yes - they will either continue to deliver on their roadmap as they have done so far, or they will miss goals.

If you're right, and they have just been busy with extracurricular activities recently, then I'll accept I reviewed their work unfairly.

This is extremely gracious of you. I'm sure the Request team will be humbled by your munificence.

Nice attempt at a jab with "extracurricular activities". Extracurricular activities like releasing the MVP and working alongside the Kyber team on a core part of the platform?

If not, you should give more consideration to the concerns I've raised.

You said there were no code comments - you just didn't look properly. You said there has been no progress in the last month - you forgot about Colossus/request.js.

I have already given your concerns more consideration than they deserve. The only reason I am replying is so that any newcomers will see your "concerns" for the easily disprovable falsehoods that they are.

-1

u/coinSceptic Jan 15 '18 edited Jan 15 '18

Colossus I discussed. Request.js I discussed. Those are the basis of what I've been looking at. The colossus project is the application front end.

It's not a 'bias' I'm flat out saying that the amount of work done does not reflect a company with the funds and objectives they've stated. I don't give a shit about whether the team wants my attention or recognition - I'm saying that I'm prepared to be wrong and I won't resolutely say that I'm right in the face of evidence to the contrary. If you think there is nothing wrong with this project and all the work is kicking along at a decent pace, great, but you're getting personal which leads me to believe you'd rather ignore everything I've said as FUD than to actually consider it. There's another guy in here who apparently raised the same concerns earlier - so apparently I'm not alone in my view here. Anyway, see you in 3 months bud.

6

u/AllGoudaIdeas Jan 15 '18

Colossus I discussed. Request.js I discussed. Those are the basis of what I've been looking at. The colossus project is the application front end.

You previously wrote:

There has been very little substantive work done over the past month

... when that "past month" included the release of Colossus and request.js. That is what I meant when I said you forgot it.

but you're getting personal which leads me to believe you'd rather ignore everything I've said as FUD than to actually consider it.

I am unsure which part of my post you consider to be "getting personal". I am more than happy to hear valid criticisms of REQ - I think it is a great project but there's always a chance there is something I missed or haven't considered, so being exposed to negative views and constructive criticism is beneficial.

However, you raised some concerns which turned out to be misleading or entirely false. If someone makes false statements in a public forum, they should expect to be corrected.

As I said, I considered - genuinely considered - all of your concerns, and found them baseless for the reasons I outlined in my previous comments.

Anyway, see you in 3 months bud.

I consider it extremely unlikely you will show up on this throwaway account in three months to admit you were wrong, but I hope to be pleasantly surprised when the time comes. I look forward to discussing the previous quarter's progress with you in the daily thread on April 1st!

0

u/[deleted] Jan 15 '18

[deleted]

-1

u/coinSceptic Jan 15 '18 edited Jan 15 '18

Ok, let's review:

Request Colossus: Q4 2017

  • Token Launch

  • First version of Request working with Ethereum on Test Net

  • Release of the API to create, read and update Requests

  • Release of the technical papers discussing architecture, upgrades, and accounting implementation details

  • Deploy the website to create, visualize and interact with Requests

  • Add Request management of accounting concepts, such as refunds, credit notes and purchase orders

Request Great Wall: Q1 2018

  • The first iteration of Request working with Ethereum on Main Net

  • Deploy management of crypto-currencies to Request (ERC20 tokens…)

  • Working on partnerships with Accounting, Payment and Audit firms

  • Launching the "Pay with Request" project: an online button which will offer an alternative to the traditional "Pay with Paypal" and "Pay with credit card" methods

  • Outside audits of the Request Contracts

  • Proof of concept: Request Core working with a Bitcoin Oracle

I see no "request management of accounting concepts" complete in Q4 2017, but perhaps I've missed something. But based on the Q1 2018 roadmap, In 3 months they need to turn the code base into a working product with a Bitcoin oracle, launch an online button as an alternative to paypal, and deploy the management of multiple crypto to request via ERC20.

I'm not sure if you're a dev or not, but take a look at the codebase. There is no foundation for the management of multiple cryptos. They are miles off implementing a production ready 'alternative to paypal button'. It's a barebones implementation of a web demo of how a request might look with a small and loose request library behind it.

If this were a 2-3 year roadmap, fine, but at the rate they are developing this is way over-scoped.

0

u/[deleted] Jan 15 '18

[deleted]

-1

u/coinSceptic Jan 15 '18

The outside audits of the Request Contracts are external code review of the fundamental request code. I believe that in fact would be considered 'dev related'.

As to your other points, well I guess we will disagree as you say. Judging by the rate of development it would be very surprising to have those goals complete in 3 months. In 3 months time if the development pace has not improved and the goals have not been met, I'll be interested to see whether you remain resolutely optimistic or not. If they have been completed, I'll be seriously impressed.

0

u/[deleted] Jan 15 '18

[deleted]

3

u/AbstractTornado ICO Investor Jan 15 '18

This is the only comment you have this account which is over 1 year old. Anyone who takes the time to look at the mods reddit accounts will see daily activity

16

u/[deleted] Jan 15 '18

[removed] — view removed comment

0

u/[deleted] Jan 15 '18 edited Jan 15 '18

[removed] — view removed comment

1

u/[deleted] Jan 15 '18

[removed] — view removed comment

0

u/[deleted] Jan 16 '18

[removed] — view removed comment

1

u/AbstractTornado ICO Investor Jan 16 '18 edited Jan 16 '18

You've been banned for revealing personal information about another user. What the fuck did you think would happen? Do you think that's ok?

0

u/[deleted] Jan 15 '18

[removed] — view removed comment

4

u/coinSceptic Jan 15 '18

Yea my aim isn't to go around and trash coins, but I want to take a really hard look at what exactly is being promised and what is being delivered. I think if REQ is a fantastic idea and I hope that it sees fruition and meets deadlines. But I also think we shouldn't be afraid to ask serious questions of teams that have had tens of millions of dollars poured into them on the basis of very ambitious goals.