r/PythonLearning • • 10d ago

Showcase I JUST finished my second python project!

Post image

Lately I have been working on this ATM For Teens, just to understand OOP and some concepts more (which I REALLY DID)

this isn't meant to be a real ATM (obviously, it's very beginner and not security is there), here is my First project.

So, I have learnt quite a lot since last project, I learnt a bit more about python syntax, I also understood the approach of classes a lot better. I learnt git (just the essentials).

Since I always wanted to Make iPhone apps, and now I have a Mac, I'm thinking whether I should start learning swift and swiftUI, or move to something else, or keep learning python. what do you guys think? I Do want a job as an IT engineer (or anything with coding tbh, cybersec too but that would require C knowledge a bit more lol)

Otherwise, if you guys have any criticism or suggestions for the ATM, then I would be veryyy happy to hear some! here's the repo: https://github.com/Stonyax97/ATM-For-Teens

255 Upvotes

34 comments sorted by

View all comments

Show parent comments

2

u/Money_Ad_5277 10d ago edited 10d ago

I'll just num all points to make it easier xD

1 Separate files/Debugging. Pycharm/VSCode has a tool (debugger) to make debugging easier, it doesn't matter home many files you have it will enter or exit them when code reaches certain points, with watch and dynamic evaluation your possibilities are almost unlimited

2 As your accounts.json is a small database

class FileDB: #(DB) can make a base class, but useless for now
def init(self, connection_string): # connection_string is your filepath self.connection_string = connection_string self._file = None

def connect(self): self._ensure_created() # your CREATING FILE STRUCTURE code corruped = self._check_corruption() # your CHECKING FOR CORRUPTED FILE that returns true if file is corrupted and false if not 
if corrupted: # usually you want to throw error, if file is corrupted, for manual fix self._recreate_file() # and problem here, if file is corrupted AGAIN, it won't check it
#Now, you can create a context manager https://www.geeksforgeeks.org/python/context-manager-in-python/ 
def __enter__(self, mode): 
 self._file = open(connection_string, mode)
 return self._file
def __exit__(self):
 self._file.close()

3 They will be a frozen objects (check @ dataclass) - but it's maybe a bit overkill for you

4 Yeah, better name should be nice but you don't need it anyway, as input() is blocking execution and a person can read everything just fine

5 PEP is general rules you want to follow if working with a team and it's focused on readability, making a new line after "if" usually means "end of code block" but you follow it with "else/elif"

6 With FileDB created, your save function will evolve into a repository In simple words: a class that is responsible for managing database entity (creation, deletion, modification or reading)

class FileUserRepository: # (Repository) - you may or may not want to create a base repository
def init(self, db): 
 self.db = db

def get_user_transactions(self, user_id):
 with self.db("r") as cursor:
  accounts = json.load(cursor)
  user = accounts.get(user_id, None) 
  if not user:     return None # or more verbose result  
  return user["transactions"] # check https://refactoring.guru/design-patterns/factory-method to create concrete transaction classes

You won't keep accounts in memory, only in accounts.json
Also assign uuid for users - easiest lookup in general
And user balance should always come from transactions + 100 - 10 couldn't possibly result in 110

7 Because it's not a error per se and program should print declination message and stop gracefully

8 Having a dictionary will help immensely

options = {
 "1": {"description": "Check balance", "action": check_balance}, # here {"description": "Check balance", "action": check_balance} could be a custom class Option("Check balance", check_balance)
 "2": {"description": "Deposit Money", "action": deposit},
}
while True:
 for k, v in options.items():
  print(f"{k}-{v["description"]}")

 user_choice = input("Choose an option: ")

 selected_option = options.get(user_choice, None)

 if selected_option:
  action = selected_option["action"]
  action() # selected_option["action"]() - is fine, but looks strange
 else:
  print("Please choose a valid option")
  # Yep, that's whole while code
print("Goodbye!") # if you throw, you won't reach this point

There can be typos)

Edit: reddit formating and return in enter method

2

u/Stonyax97 9d ago

Hey!

Ive took the time to actually understand this and look up the terms.

this is gold advice, thank you so much. but at this scale? it makes NO SENSE.

first the FileDB. why should I create my own wrapper when with open() does the job for me?
I agree with the fact that it would help make the code cleaner plus no scattered with open file everywhere.

for the data class that's frozen, I agree too, transactions are meant to be frozen. il try to look into it.

Il set up PEP right now and start using it! thanks!

"Also assign uuid for users - easiest lookup in general"
when logging in, I wouldn't possibly ask for the user to input UUID. id have to loop through each dict to find the username inside it, then use dict.keys() to get the UUID. kinda complex. but I get the approach, many people will have the sane name. yk this project is just for fun and learning not a real project lol. that's very clear the way passwords are stored.

"You won't keep accounts in memory, only in accounts.json"

wouldn't they need to stay in memory when interacting with it eventually?

for the balance being. created using transactions history. that is SMART. I love it. I would implement this in v1.2.2.

"7. Because it's not a error per se and program should print declination message and stop gracefully"

I forgot the thing we where talking about here could u re explain LOL sorry

8. I understand the approach here, and it's actually smart, but wouldn't that action() result in too many functions?

1

u/Money_Ad_5277 9d ago

I understand that it can make no sense, but I was given a problem like this and was forced to do it this way xD
And most of my tips are fixes of my errors from back than

FileDB. repositories - yes, overkill, but when you want to switch to real db (or api), or even test an app, they come in handy. Because form is almost as important as content

uuid - when user log in, you store only uuid, without email, password and whole transaction array.
Also having array of users like [{id: 1, username: "user 1"}, {id: 2, username: "user 2"}]
Lookup by id becomes
user, *_ = list(filter(lambda user: user["id"] == user_id)) or [None] # python devs are going to kill me for that

You can change key to username to lookup user by username.

Accounts in memory - yes - for file approach, but only for a short period of time, no - for db approach

7 you raised an error on line 256 to exit program instead of using break

8 Yes, but it's common problem of all apis, you can't magically understand what user wants and transform it to a function

2

u/Stonyax97 9d ago

Ah yeah I see. Thanks 🙏

Btw what’s your current status with coding/programming? Is it your job? Hobby? Or side project?

1

u/Money_Ad_5277 9d ago

Hobby -> field of study -> job

2

u/Stonyax97 9d ago

where are you now?

2

u/Money_Ad_5277 9d ago

At job and field of study steps

1

u/Stonyax97 9d ago

Oh that’s nice dude wish you the best. I also want to follow in the same steps. In what field are you? Backend, front end? Cybersec?

→ More replies (0)