r/Python • u/CryptoBlocks257 • Mar 13 '21

Intermediate Showcase Multiplayer Framework For Pygame

Hey everyone here is a little framework I made to help you get started making multiplayer games with Pygame and Sockets. The framework comes with movement and jumping over the network here is the GitHub repo - https://github.com/Len-Stevens/Pygame-Multiplayer-Framework

23 Upvotes

56% Upvoted

40 comments sorted by

36

u/krumg Mar 13 '21

Hey,
Not sure if you'd want a code review but here's one:
* No tests
* Blocks of commented out code left there for no reason
* `print`s in the code
* And generally the code quality is terrible on all possible levels

And it doesn't look even close to a final product and yet you ask for donations.

16

u/[deleted] Mar 13 '21

And yet it has 85% upvoted at this point. Do people really just never click and read stuff?

12

u/Caboose522 Mar 13 '21

Can you really call it a framework? I'm no expert in making games but why would 200 lines of code warrant donations either?

9

u/[deleted] Mar 13 '21

It could be a framework but to ask for donations for something like that is... let‘s call it brave

-3

u/CryptoBlocks257 Mar 13 '21

I do apologize for that, looking back on it, asking for donations on a project this small wasn't a very smart move and I definitely over valued this project since I was pretty excited when I got it to work.

13

u/Thifty Mar 13 '21

I get that it’s not top quality and can use a lot of improvements, but why so harsh on the dude? Just offer suggestions and give your thoughts, don’t shame someone because they don’t have as much experience as you. That’s just toxic

11

u/Laser_Plasma Mar 13 '21

Honestly, I'm just extremely annoyed at the Dunning-Kruger OP clearly has. At his level it'd make sense to ask for feedback and how he could improve the project, and not market it as a framework and ask for money. Some modesty, please.

-1

u/Thifty Mar 13 '21

I mean I completely agree but being a dick isn’t gonna help him come to that realization. Well it might, but definitely not the way it should be done

9

u/Laser_Plasma Mar 13 '21

I feel like different people in this thread have a different sense of what "being a dick" means. In my opinion, nothing so far has really qualified as that. On the other hand, saying "You suck and should stop coding" would.

0

u/Thifty Mar 13 '21

I mean saying “And generally the code quality is terrible on all possible levels” is like the same thing to me, but I guess you're right

-1

u/gamboty Mar 13 '21

The Danning Kruger Effect is completely normal. People learn differently and some people also need that effect to have a significant pride at the beginning of their path. You even calling this by its name is just rude, because it helps no one. This post isn‘t about you, so you don‘t have to justify your original answer. „You are annoyed“ by the OP (directly or indirectly) because he posted something he is proud of. This literally doesn’t hurt anyone, so why do you have such a heavy reaction to it?

9

u/[deleted] Mar 13 '21

Because he asks for donations , simple as that

-3

u/Thifty Mar 13 '21

So you’re a dick to him? Just tell him that it’s not at that point. I agree it’s a bit odd, but still

8

u/[deleted] Mar 13 '21

Nobody is being a dick. This thing has the intermediate showcase flair, 50% of the readme is asking for donations, it‘s neither pygame related nor a framework...

Calling the code terrible at „intermediate level“ may not be the nicest wasy to do review but it‘s als not being a dick.

2

u/Thifty Mar 13 '21

“ And generally the code quality is terrible on all possible levels”

Ah yes very constructive and kind hearted

1

u/whateverathrowaway00 Mar 14 '21

It’s the asking for money bit. Otherwise I think the feedback he got would’ve been significantly kinder.

1

u/Noremorse150 Mar 14 '21

Gifs are mesmerizing for some

-2

u/Hermasetas Mar 13 '21

It's not great but I don't see a reason to downvotes it

2

u/[deleted] Mar 13 '21

While I disagree with his code, testing game code is quite difficult. Unless you want to mock out Pygame functionality it's generally untestable. For the game I'm working on I settled with a shell script that uses xdotool to manually assert some stuff. Not great but it works.

-6

u/[deleted] Mar 13 '21

[removed] — view removed comment

13

u/krumg Mar 13 '21

Code review is exactly how you tell someone about things which require improvements.

10

u/kill_will_ Mar 13 '21

“And generally the code quality is terrible on all possible levels”

Is not helpful, is not constructive and it’s certainly not code review

8

u/Thifty Mar 13 '21

Exactly what I said, and they downvoted me too lol. It’s just plain mean and demotivating, if I just posted something I thought was awesome and got this response I’d be crushed

3

u/kill_will_ Mar 13 '21

Well you can have my upvote. I agree that it needs work. But if you’re just going to leave some vague advice about it being bad, maybe just not comment.

Especially under the guise of being helpful. Dude was not trying to be constructive, he was just being snarky.

8

u/krumg Mar 13 '21

My review would be much friendlier and more detailed if this guy posted his repo and said something like "Hey, I've started learning python. Please tell me how to improve my code.".

But he posted some shitty 150 lines, called them a "framework" and asked for donations.

Difference between these 2 scenarios seems to be obvious to me.

3

u/[deleted] Mar 13 '21

People seem to really not get that your review is 100% appropriate given the context. You would be a jerk to review a beginner showcase like that but in this context? Nah

5

u/krumg Mar 13 '21

Sure, it's all about the context.

1

u/Thifty Mar 13 '21

Yep, for some reason this sub (atleast used to) have a problem with that

2

u/krumg Mar 13 '21

So you took this phrase out out of context and made some conclusions. Nice. Really constructive.

-1

u/Thifty Mar 13 '21

Please, give us some context. It was literally a bullet point, a standalone comment, as part of his "code review".

4

u/krumg Mar 13 '21

Sure. My comment can be pseudocoded like that:

* That's missing  
* That's wrong   
* That's quite bad  
* And to be honest all code is so bad that it is impossible to highlight anything special  
And you dared to ask for donations!?

Hope it makes sense

1

u/backtickbot Mar 13 '21

Fixed formatting.

Hello, krumg: code blocks using triple backticks (```) don't work on all versions of Reddit!

Some users see this / this instead.

To fix this, indent every line with 4 spaces instead.

FAQ

You can opt out by replying with backtickopt6 to this comment.

-1

u/Thifty Mar 13 '21

I have literally no idea what you're trying to say lol. But, you do realize you can be nice to people, right? Even in the context you're speaking. There's no reason to make someone feel bad about what they did or posted when they clearly were under a different interpretation. I'm not sure you're trying to hide behind the argument that it's OK.

6

u/krumg Mar 13 '21

I'm very nice and helpful to others most of the time. But in this case someone is spamming (check his posts history) with low quality code asking for donations.

Would you send him a donation if you support him so much?

2

u/[deleted] Mar 14 '21

Just don't call it a framework and I'm happy lol

2

u/PinBot1138 Mar 13 '21

I’m upvoting for effort and because I don’t want you to lose hope, but there’s a lot of room for improvement here.

-6

u/gamboty Mar 13 '21

I think people here are being dicks. If someone sets up donations for something not good enough, he will know that soon enough. No point in telling it. Also, try to remember how you felt when starting with stuff like this. First you do, then you understand how hard stuff really is. That‘s completely normal.

0

u/[deleted] Mar 13 '21

[deleted]

24

u/Laser_Plasma Mar 13 '21

For real, people write like a 150-line long demo, call it a framework and then drop their BTC wallet in the readme lmao

1

u/Original-Curious Mar 14 '21

😂😂 savage