r/Python • • Jun 22 '18

Python patch, first try.

Post image
1.3k Upvotes

42 comments sorted by

155

u/Oisota Jun 23 '18

Is it multithreaded?

4

u/chillermane Jun 26 '18

Yes but only one thread may run at a time.

14

u/[deleted] Jun 23 '18

Underappreciated comment

144

u/RelevantToMyInterest Jun 23 '18

Patch notes available?

48

u/strange-humor Jun 23 '18

Wow, I did not know that format was supported in Pillow yet. Cool.

57

u/monkJs Jun 22 '18

Where there any dependencies involved?

51

u/[deleted] Jun 22 '18

From fiber import string

14

u/Fashish Jun 23 '18

Would it significantly decrease the processing time if you just did a import fiber instead?

9

u/[deleted] Jun 23 '18

But we want string, not food fiber, fiber optics, muscle fiber, that stringy stuff inside a pumpkin. This is why we need to be specific

1

u/Fashish Jun 23 '18

But you might wanna to use one (or more) later on, and then would have to import them separately again, no?

For example, I might wanna frame it with wheat-woven strings and then have fiber optic lasers run through the inner patterns. I would have do two separate imports. Insane!

3

u/[deleted] Jun 23 '18

Nah dood:

from fiber import string,wheat,optic from light import laser

3

u/Fashish Jun 23 '18

Well, damn. I’ve been doing the whole laser thing wrong all this time. TIL. Thanks dood!

3

u/[deleted] Jun 24 '18

I gotchu dood

0

u/[deleted] Jun 23 '18

[deleted]

3

u/BrendonOS Jun 24 '18

This whole conversation is hilarious

12

u/RunToImagine Jun 23 '18

Is this python 2 or 3?

11

u/MartyMacGyver from * import * Jun 23 '18

Your patch submission has been accepted!

11

u/[deleted] Jun 23 '18

All silliness aside, I want one.

5

u/lifeonm4rs Jun 23 '18

Yeah, How do I git one?

10

u/zitterbewegung Jun 23 '18

Can you create a new branch for this patch with the issue number since this issue doesn't exist yet?

4

u/BelieveRL Jun 23 '18

Is this patch good for both 2.7 and 3.6? Is it cross compatible ?

8

u/Accidental_Arnold Jun 23 '18

no, if you want to use 2.7 you need:

from __future__ import sewing_skills

4

u/[deleted] Jun 23 '18

Has this been reviewed as there are far too many holes in the design for my liking?

4

u/brtt3000 Jun 23 '18

Python keeps messing with the string formatting.

14

u/daves Jun 23 '18

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

...

Thanks again to your contribution and we look forward to looking at it!

5

u/Steven__hawking Jun 23 '18

What?

6

u/daves Jun 23 '18

The universal first response to your first Python patch.

e.g. https://github.com/python/cpython/pull/7862

3

u/casual_brooder Jun 23 '18

wut?

-bot

3

u/Steven__hawking Jun 23 '18

Wat?

1

u/[deleted] Jun 23 '18

Wot m8

3

u/CiceroJFaraday Jun 23 '18

I like the python logo so much more, now

3

u/shotazc Jun 23 '18

Nice patch work.

2

u/flutefreak7 Jun 23 '18

Can I deploy this with fabric?

2

u/PM_ME_TECHNO_TRACKS Jun 24 '18

Anyone coming into this thread better pip install puns before continuing

2

u/jadore801120 Jun 23 '18

Is it for 2 or 3?

1

u/abdoulsn Jun 23 '18

Nice try

1

u/[deleted] Jun 23 '18

Not bad

1

u/Hayderp Jun 23 '18

They look like dudes with open mouths and a beards like this

-8

u/Neighborhood_Pedo Jun 23 '18

black panther was ok

-8

u/Neighborhood_Pedo Jun 23 '18

black panther was ok

0

u/[deleted] Jun 23 '18

[deleted]

2

u/[deleted] Jun 23 '18

Me too