r/ProgrammerHumor • u/juicyjurgenz • Mar 01 '16
Udemy offering javascript course with JAVA logo
4
3
1
u/htmlcoderexe We have flair now?.. Mar 01 '16
Looks shopped.
5
u/juicyjurgenz Mar 01 '16
nope, you can see it here) https://www.udemy.com/javascript-high-performance/
3
u/Donnarhahn Mar 02 '16
Not any more. Looks like they changed it.
2
u/juicyjurgenz Mar 02 '16
Yup, now it's different :)
3
u/ligerzero459 Mar 02 '16
Someone probably emailed them saying "you know those aren't the same, right?"
3
5
u/htmlcoderexe We have flair now?.. Mar 01 '16
The image there looks shopped
6
2
u/phpdevster Mar 03 '16
Yep. Sloppy job too. Couldn't even find a transparent PNG of the java logo, they just used something with a background... I don't know what bothers me more: the lazy photoshop work or the use of the java logo, or even the decision to include a language logo of any kind on the image.....
4
2
u/CupsOP Mar 02 '16
The inline JavaScript rustled my jimmies
1
Mar 03 '16
I dunno... The HTML comment guards (what is this, 2001?), commented out code, inconsistent use of single and double quotes, type="javascript", use of tables (WITH INLINE CSS AND HARDCODED WIDTH!) and the method of generating HTML from within JS kinda pissed me off more.
Oh, and the <script> tag is right outside the </body> close tag.
Basically, fuck that code. That really gives the course a very bad impression in many ways.
1
Mar 09 '16
In addition to what you said:
Global variables (
page) used everywhere (in the function and in inline JS)Global variables
Not using the strict equality comparator
Inline JS events (
onclick)Multiple JS statements in inline event handler (
onclick)160 lines of HTML followed by Crockford knows how many of JavaScript
Anchor with
href="#", not even returning false fromonclickeventVariable width font in what is obviously a professional IDE (it has code folding)
Lines at least 100 characters wide (I counted 50 up until around the middle of the last line)
Variables declared and assigned long before where they're used (
j)Spaces after
(and before)(ifstatement)The
'1'is a bit of a smell, too (why would you need the unit integer as a string?)Hard-coded paths to images
document.getElementByIdused twice instead of defining a shorthandReferencing the same element with
document.getElementByIdtwice, instead of assigning it to a variableReferencing what looks like elements with dynamic ids using hard-coded values (
bigImage0andbigImage1)Using
style.displayinstead of CSS classes
<tr>inside table without<tbody>We're going to need an old priest and a young priest here.
1
26
u/MrMeseeks_ Mar 01 '16
Java is to Javascript
as Car is to Carpet