This is not a post to bash other systems, but rather promote a healthy discussion about damage system for ADCs in LoL. There are two basic premises of every damage system in LoL:
1 - Whenever a system is underpowered, its users are greatly affected and become less viable.
2 - Making some champions less viable because an inherent damage system they use is weak means some champions or roles that are weak vs said damage system are now suddenly out of counters.
3 - No damage system is fully locked in a role ; according to the power each system has, some champions who were not designed with that system in mind will eventually turn to other systems.
Now, what IS a damage system? Simply put, the group of items in which leads to a coherent and cohesive build for a particular champion or for a group of champions. It's best to list them to understand. Currently, in ADC role, there are these main systems (not listed necessarily according to their power right now)
1 - Crit users. Jinx, Ashe, Yunara, Twitch, etc. Basically all these champions want the trinity of AD, AS and crit so they scale with doing several hundreds worthy of AD per second.
2 - Critality users. MF, Jhin, Draven, Caitlyn, Nilah, Samira etc. These champions have some significant power in their abilities and/or have attack speed abilities that reduce their need for attack speed items. Thus, they want a build with AD, lethality and crit chance.
3 - On-hit systems. On-hit Vayne, Varus, Kai'Sa, Kalista, Kog'Maw. These champions have some ability that does some damaging effect on-hit and thus heavily benefit from Guinsoo Rageblade and want to go other on-hit items since they are already planning going for Guinsoo.
4 - Triforce systems. Ezreal and Corki almost exclusively. These champions have a way of proccing Sheen easily and thus can abuse an early powerspike from Triforce Sheen effect giving them 200% base AD on many attacks but also giving HP, MS, AD, AS.
5 - AP systems. Mage bot have existed for many years already. The idea is doing magic damage scaling with AP rather than physical damage scaling with AD.
Because of our premises, when a system is *weak*, other systems get more popular. And currently, this system is on-hit.
From a class -counter-class perspective, many on-hit champion effects do %HP damage tied to magic or pure damage, so they are naturally harder to itemize defensively against and simply stacking HP does not automatically make them weaker. This is generally not relevant versus ADCs, but this trait makes them natural tankbusters or, at least, HP stackers busters. From a class-vs-itself perspective, they have more power allocated into DPS with attacks rather than with spells ; this should make enemies focus on proper spacing and, when spacing was poor or a jungler has come to gank 3v2, this should make these ADCs boom with damage
What happens, however, when this system is not strong enough? Predictably, the opposite of the above paragraph. Many ADCs decide that facing an on-hit ADC on their attack range is not dangerous enough and get improperly strong not due to their strengths, but due to the enemy strengths being unavailable. Tanks now decide that, hey, why bothering building HP, armor and MR, if building HP and some MR to not get bursted by mages is enough, and armor is completely fine to be postponed for 3rd item or, when a heavy AD comp, just build HP and armor and now slots are free for other stuff.
On-hit system was already listed by Riot and some of its devs as a weak system. However, few changes ever since that announcement has been made, and, as a result, the class is less diverse and has more outliers (aka mages outside of Ziggs and Yasuo bot) playing it to fulfill the power vacuum a weak on-hit system has left.