r/programming • • Feb 06 '19

Visual Studio Code: January 2019 (version 1.31)

https://code.visualstudio.com/updates/v1_31
790 Upvotes

340 comments sorted by

View all comments

Show parent comments

35

u/coderstephen Feb 07 '19

I'd say Electron is the weakest point of the app. I think it's about the only Electron app I've used that actually feels fast and efficient; likely the core code base is well-designed, bloat-free, and designed to be performant.

-15

u/yird Feb 07 '19

Not really, no matter what you put on top of electron it’s still electron. There’s no getting away from it as long as your app is built on top of it.

31

u/coderstephen Feb 07 '19

I know it is still Electron. My point is that VS Code feels quite fast despite that fact. Do you disagree that it feels fast? Or do you have some sort of other problem with using Electron?

I don't have any kind of ideological problem with Electron. It's just a tool. My problems with it is:

  • It is easy to make really slow, memory-hogging apps with it unless you really focus on optimization.

  • Large distribution sizes.

  • I don't prefer CSS/HTML/JS for UI.

  • It really is a sub-optimal approach to the problem, but their primary goal is developer productivity anyway.

These are mostly problems an app developer has to address. But as an end-user of VS Code, the only thing that really concerns me is the first point, and VS Code seems to have solved it. Thus, I have no reason to discard VS Code just because it uses Electron.

9

u/coderstephen Feb 07 '19

Another point:

Not really, no matter what you put on top of electron it’s still electron.

This is Electron: https://github.com/electron/electron. VS Code's core application and UI logic (written in TypeScript) isn't Electron. It's VS Code. That's why it isn't in the Electron repo...

I'd dare to say that VS Code's performance is empirical. How do you explain that? Somehow they must have figured out a way of using Electron without making a sluggish beast like Slack is.

Sure it still uses Electron, but if they can make it fast I honestly don't care.

1

u/TheIronMiner Feb 07 '19

How come installing Vs code on Linux then provides me with electron as well :/

4

u/coderstephen Feb 07 '19

It's called a dependency.

1

u/TheIronMiner Feb 07 '19

You do realise what you are saying right?

Like, "sure a car has uses an engine. Sure are car has an engine. But cars don't need engines to run, it's called a dependency".

1

u/coderstephen Feb 08 '19

I was, slightly sarcastically, refuting the claim that a car is an engine, or rather vscode != electron.

What you're describing is an optional dependency, which I did not claim Electron was for VS Code.

0

u/DrunkensteinsMonster Feb 07 '19

This might be the stupidest thing I’ve ever read, take an upvote

-1

u/yird Feb 07 '19

It takes up a lot of resources that’s why it’s not sluggish, chrome does the same thing