Code reviews are primarily for making sure coding standards are met. Found a bug or code that won't work, great! But the focus is reviewing code, not acceptance criteria.
Coding standards can be initially met with automated tools such as Codacy, Sonar etc, sometimes even locally, before a commit is pushed.
In the .Net world, we have various ways to approach this, including static code analysis, and setting quality gates on whatever we have set as criteria, as part of the pull request process. These tools exist for many languages.
If you organise your projects properly with editor config files, defined settings shared between developers, then it is usually not a problem, and most of these issues should not really get to the Code Review stage.
In most cases, a developer will adjust the way they approach code organisation to match existing approaches within the team, quite quickly.
For me personally, Code Reviews can include verification that Business Logic has been implemented correctly. For example, verifying that Tests, do actually test the requirements, and are not simply there for code coverage.
Otherwise, there is really not much value added by having another team member look at your code, and it just becomes an exercise in rubber-stamping.
3
u/CT101823696 Jun 07 '22
Code reviews are primarily for making sure coding standards are met. Found a bug or code that won't work, great! But the focus is reviewing code, not acceptance criteria.